github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6789] [MERGED] fix: preserve = padding in parsed cookies #6884

New Issue
Closed
opened 2026-03-13 13:15:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:15:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6789
Author: @Shridhad
Created: 12/16/2025
Status: ✅ Merged
Merged: 12/16/2025
Merged by: @himself65

Base: canary ← Head: fix/parse-cookies

📝 Commits (1)

  • f238277 fix: securely parse request cookies

📊 Changes

2 files changed (+37 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/cookies/cookies.test.ts (+36 -1)
📝 packages/better-auth/src/cookies/index.ts (+1 -1)

📄 Description

Sometimes the signed cookies end with signature padding =, which causes issue with parseCookies to exclude them while parsing request cookies.

The current implementation splits each cookie with = to format into key-value pair, however, if cookie value contains = it is split into into three parts, ignoring the last part. Example breaking tests:

better-auth:test:  FAIL  src/cookies/cookies.test.ts > parse cookies > should securely parse the signed cookies with padding
better-auth:test: AssertionError: expected 'session-token.signature' to be 'session-token.signature=' // Object.is equality
better-auth:test:
better-auth:test: Expected: "session-token.signature="
better-auth:test: Received: "session-token.signature"
better-auth:test:
better-auth:test:  ❯ src/cookies/cookies.test.ts:1121:58
better-auth:test:     1119|   const parsedCookies = parseCookies(cookieHeader);
better-auth:test:     1120|
better-auth:test:     1121|   expect(parsedCookies.get("better-auth.session_token")).toBe("session-token.signature=");
better-auth:test:        |                                                          ^
better-auth:test:     1122|   expect(parsedCookies.get("better-auth.session_data")).toBe("session-data.signature=");
better-auth:test:     1123|  })

This change splits the individual cookie by first = ensure only two parts.

Summary by cubic

Fix cookie parsing to preserve "=" padding in signed cookies by splitting on the first "=". This prevents truncation and ensures session cookies are read correctly from request headers.

  • Bug Fixes
    • Updated parseCookies to split on the first "=" (using /(=(.*)/s)) so values with padding are preserved.
    • Added tests for signed cookies with "=" padding to prevent regressions.

Written for commit f238277de1. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6789 **Author:** [@Shridhad](https://github.com/Shridhad) **Created:** 12/16/2025 **Status:** ✅ Merged **Merged:** 12/16/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/parse-cookies` --- ### 📝 Commits (1) - [`f238277`](https://github.com/better-auth/better-auth/commit/f238277de147a81d19a570d92391e8e3cc8b937d) fix: securely parse request cookies ### 📊 Changes **2 files changed** (+37 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/cookies/cookies.test.ts` (+36 -1) 📝 `packages/better-auth/src/cookies/index.ts` (+1 -1) </details> ### 📄 Description Sometimes the signed cookies end with signature padding `=`, which causes issue with `parseCookies` to exclude them while parsing request cookies. The current implementation splits each cookie with `=` to format into key-value pair, however, if cookie value contains `=` it is split into into three parts, ignoring the last part. Example breaking tests: ```sh better-auth:test: FAIL src/cookies/cookies.test.ts > parse cookies > should securely parse the signed cookies with padding better-auth:test: AssertionError: expected 'session-token.signature' to be 'session-token.signature=' // Object.is equality better-auth:test: better-auth:test: Expected: "session-token.signature=" better-auth:test: Received: "session-token.signature" better-auth:test: better-auth:test: ❯ src/cookies/cookies.test.ts:1121:58 better-auth:test: 1119| const parsedCookies = parseCookies(cookieHeader); better-auth:test: 1120| better-auth:test: 1121| expect(parsedCookies.get("better-auth.session_token")).toBe("session-token.signature="); better-auth:test: | ^ better-auth:test: 1122| expect(parsedCookies.get("better-auth.session_data")).toBe("session-data.signature="); better-auth:test: 1123| }) ``` This change splits the individual cookie by first `=` ensure only two parts. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix cookie parsing to preserve "=" padding in signed cookies by splitting on the first "=". This prevents truncation and ensures session cookies are read correctly from request headers. - **Bug Fixes** - Updated parseCookies to split on the first "=" (using /(=(.*)/s)) so values with padding are preserved. - Added tests for signed cookies with "=" padding to prevent regressions. <sup>Written for commit f238277de147a81d19a570d92391e8e3cc8b937d. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:15:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6884
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?