github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6614] [MERGED] chore: add nonce check and verifying jwt claims for google #6779

New Issue
Closed
opened 2026-03-13 13:11:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:11:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6614
Author: @jonathansamines
Created: 12/8/2025
Status: ✅ Merged
Merged: 12/8/2025
Merged by: @Bekacru

Base: canary ← Head: feat/verify-google-jwt

📝 Commits (1)

  • 46be831 feat(better-auth): verify google jwt claims

📊 Changes

1 file changed (+46 additions, -17 deletions)

View changed files

📝 packages/core/src/social-providers/google.ts (+46 -17)

📄 Description

Closes https://github.com/better-auth/better-auth/issues/6521

Summary by cubic

Verifies Google ID tokens by checking JWT signatures and claims against Google’s JWKs, replacing the tokeninfo lookup. Improves security and correctness of Google auth.

  • New Features
    • Added getGooglePublicKey to fetch/import JWKs and verify tokens with jose.
    • Enforced issuer, audience (clientId), nonce match, and a 1h max token age.
    • Returns false on invalid headers or nonce mismatch; throws APIError if keys are missing.
    • Still supports a custom options.verifyIdToken override.

Written for commit 46be831212. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6614 **Author:** [@jonathansamines](https://github.com/jonathansamines) **Created:** 12/8/2025 **Status:** ✅ Merged **Merged:** 12/8/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `feat/verify-google-jwt` --- ### 📝 Commits (1) - [`46be831`](https://github.com/better-auth/better-auth/commit/46be831212ab3ebe507f12f150a07ebc126ead36) feat(better-auth): verify google jwt claims ### 📊 Changes **1 file changed** (+46 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/social-providers/google.ts` (+46 -17) </details> ### 📄 Description Closes https://github.com/better-auth/better-auth/issues/6521 <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Verifies Google ID tokens by checking JWT signatures and claims against Google’s JWKs, replacing the tokeninfo lookup. Improves security and correctness of Google auth. - **New Features** - Added getGooglePublicKey to fetch/import JWKs and verify tokens with jose. - Enforced issuer, audience (clientId), nonce match, and a 1h max token age. - Returns false on invalid headers or nonce mismatch; throws APIError if keys are missing. - Still supports a custom options.verifyIdToken override. <sup>Written for commit 46be831212ab3ebe507f12f150a07ebc126ead36. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:11:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6779
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?