github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6470] [CLOSED] chore: fix siwe tests not matching error message #6688

New Issue
Closed
opened 2026-03-13 13:08:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:08:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6470
Author: @jslno
Created: 12/2/2025
Status: ❌ Closed

Base: canary ← Head: 12-02-2025/fix-siwe-tests

📝 Commits (1)

📊 Changes

1 file changed (+10 additions, -4 deletions)

View changed files

📝 packages/better-auth/src/plugins/siwe/siwe.test.ts (+10 -4)

📄 Description

Summary by cubic

Updated SIWE plugin tests to match the new, detailed validation error messages so assertions stop failing and reflect current API behavior.

  • Bug Fixes
    • Assert walletAddress pattern and length errors for nonce requests.
    • Assert email required error when anonymous=false.
    • Assert invalid email error.
    • Assert combined email errors for invalid and required cases.

Written for commit 1feaff64d6. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6470 **Author:** [@jslno](https://github.com/jslno) **Created:** 12/2/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `12-02-2025/fix-siwe-tests` --- ### 📝 Commits (1) - [`1feaff6`](https://github.com/better-auth/better-auth/commit/1feaff64d6225da555699a213988db14e8a92205) chore: fix siwe tests ### 📊 Changes **1 file changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/siwe/siwe.test.ts` (+10 -4) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Updated SIWE plugin tests to match the new, detailed validation error messages so assertions stop failing and reflect current API behavior. - **Bug Fixes** - Assert walletAddress pattern and length errors for nonce requests. - Assert email required error when anonymous=false. - Assert invalid email error. - Assert combined email errors for invalid and required cases. <sup>Written for commit 1feaff64d6225da555699a213988db14e8a92205. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:08:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6688
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?