github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6404] [CLOSED] docs: apply canonical classes & minor improvements #6643

New Issue
Closed
opened 2026-03-13 13:06:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:06:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6404
Author: @jslno
Created: 11/29/2025
Status: ❌ Closed

Base: canary ← Head: 11-29-2025/cleanup-docs-components

📝 Commits (10+)

  • d00ba0d docs: apply canonical class suggestions
  • 93328b4 chore: remove deprecated React.ElementRef
  • 9d98c29 chore: fix linting
  • dcd037b chore: remove chart component
  • e89fdee chore: add types for hast
  • cc3ebba chore: apply remaining canonical class names
  • 1a03c38 chore: fix CodeBlockTabs props
  • d7ede75 chore: fix linting
  • df00a63 feat(builder): simulate loading
  • 2bf2dc4 chore: mark icons as aria-hidden

📊 Changes

74 files changed (+570 additions, -648 deletions)

View changed files

📝 docs/app/blog/[[...slug]]/page.tsx (+9 -3)
📝 docs/app/blog/_components/_layout.tsx (+4 -4)
📝 docs/app/blog/_components/blog-list.tsx (+1 -1)
📝 docs/app/blog/_components/default-changelog.tsx (+7 -7)
📝 docs/app/blog/_components/stat-field.tsx (+4 -4)
📝 docs/app/changelogs/_components/_layout.tsx (+4 -4)
📝 docs/app/changelogs/_components/default-changelog.tsx (+7 -7)
📝 docs/app/changelogs/_components/grid-pattern.tsx (+2 -2)
📝 docs/app/changelogs/_components/stat-field.tsx (+4 -4)
📝 docs/app/community/_components/stats.tsx (+26 -14)
📝 docs/app/docs/[[...slug]]/page.client.tsx (+19 -5)
📝 docs/app/docs/[[...slug]]/page.tsx (+5 -3)
📝 docs/app/page.tsx (+1 -1)
📝 docs/app/v1/_components/v1-text.tsx (+1 -1)
📝 docs/app/v1/bg-line.tsx (+1 -1)
📝 docs/app/v1/page.tsx (+4 -4)
📝 docs/components/ai-chat-modal.tsx (+13 -10)
📝 docs/components/api-method.tsx (+4 -3)
📝 docs/components/banner.tsx (+1 -1)
📝 docs/components/blocks/features.tsx (+3 -3)

...and 54 more files

📄 Description

  • Applied suggested canonical classes
  • Removed unused chart component
  • Fixed CodeBlockTabs props error
  • Added aria-hidden to svg icons
  • Added simulated loading state for builder

Summary by cubic

Standardized docs components to Tailwind v4 canonical classes and fixed TypeScript types to remove build errors. Improved accessibility for icons and added loading simulation to Builder auth forms.

  • Refactors

    • Replaced legacy utilities with canonical classes (e.g., bg-gradient-to-* → bg-linear-to-*, h-[1px] → h-px, min-w-[32rem] → min-w-lg, z-[1] → z-1).
    • Normalized arbitrary values and data attributes (e.g., data-[inset] → data-inset), updated mask/background syntax, and standardized grow/shrink utilities.
    • Unified CSS variable usage across components (e.g., w-(--radix-...) and h-(--radix-...)).
    • Removed deprecated Chart UI component.
    • Added simulated loading states to Builder sign-in/sign-up.

  • Bug Fixes

    • Fixed forwardRef typings (ComponentRef) and React component prop types to resolve TS errors.
    • Corrected CodeBlockTabs MDX prop handling to avoid rendering issues.
    • Removed unused code in sign-up and corrected minor UI issues (border, spacing, z-index, sticky/overflow).
    • Marked non-interactive icons as aria-hidden and added labels where needed to improve screen reader support.
    • Added @types/hast and @types/js-beautify to address missing types; updated lockfile accordingly.

Written for commit ffd3dfcaf7. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6404 **Author:** [@jslno](https://github.com/jslno) **Created:** 11/29/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `11-29-2025/cleanup-docs-components` --- ### 📝 Commits (10+) - [`d00ba0d`](https://github.com/better-auth/better-auth/commit/d00ba0d8c17e23e318e76570a9f6e0621a7f9443) docs: apply canonical class suggestions - [`93328b4`](https://github.com/better-auth/better-auth/commit/93328b44dcfda4b9a62e8b15d02ca5c0685acdbb) chore: remove deprecated `React.ElementRef` - [`9d98c29`](https://github.com/better-auth/better-auth/commit/9d98c2936efcd5b3ae39108860b5c625870fc70f) chore: fix linting - [`dcd037b`](https://github.com/better-auth/better-auth/commit/dcd037b51c947e5cfe4afd7de90852931260a709) chore: remove chart component - [`e89fdee`](https://github.com/better-auth/better-auth/commit/e89fdee3bbf59507008f4e15d0dbdd34c6e47d67) chore: add types for `hast` - [`cc3ebba`](https://github.com/better-auth/better-auth/commit/cc3ebba946d4292d4f6a5cf5752e5b07eb3a34c6) chore: apply remaining canonical class names - [`1a03c38`](https://github.com/better-auth/better-auth/commit/1a03c38426cabf1bb5b6418eff659f24f379e37b) chore: fix CodeBlockTabs props - [`d7ede75`](https://github.com/better-auth/better-auth/commit/d7ede75294c067237590f4aaad6e22121513898c) chore: fix linting - [`df00a63`](https://github.com/better-auth/better-auth/commit/df00a6353fda810ddc8c11a0814ac97d50f0b355) feat(builder): simulate loading - [`2bf2dc4`](https://github.com/better-auth/better-auth/commit/2bf2dc48213b1ff40934b048529f4d782b9d052f) chore: mark icons as aria-hidden ### 📊 Changes **74 files changed** (+570 additions, -648 deletions) <details> <summary>View changed files</summary> 📝 `docs/app/blog/[[...slug]]/page.tsx` (+9 -3) 📝 `docs/app/blog/_components/_layout.tsx` (+4 -4) 📝 `docs/app/blog/_components/blog-list.tsx` (+1 -1) 📝 `docs/app/blog/_components/default-changelog.tsx` (+7 -7) 📝 `docs/app/blog/_components/stat-field.tsx` (+4 -4) 📝 `docs/app/changelogs/_components/_layout.tsx` (+4 -4) 📝 `docs/app/changelogs/_components/default-changelog.tsx` (+7 -7) 📝 `docs/app/changelogs/_components/grid-pattern.tsx` (+2 -2) 📝 `docs/app/changelogs/_components/stat-field.tsx` (+4 -4) 📝 `docs/app/community/_components/stats.tsx` (+26 -14) 📝 `docs/app/docs/[[...slug]]/page.client.tsx` (+19 -5) 📝 `docs/app/docs/[[...slug]]/page.tsx` (+5 -3) 📝 `docs/app/page.tsx` (+1 -1) 📝 `docs/app/v1/_components/v1-text.tsx` (+1 -1) 📝 `docs/app/v1/bg-line.tsx` (+1 -1) 📝 `docs/app/v1/page.tsx` (+4 -4) 📝 `docs/components/ai-chat-modal.tsx` (+13 -10) 📝 `docs/components/api-method.tsx` (+4 -3) 📝 `docs/components/banner.tsx` (+1 -1) 📝 `docs/components/blocks/features.tsx` (+3 -3) _...and 54 more files_ </details> ### 📄 Description - Applied suggested canonical classes - Removed unused chart component - Fixed CodeBlockTabs props error - Added `aria-hidden` to svg icons - Added simulated loading state for builder <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Standardized docs components to Tailwind v4 canonical classes and fixed TypeScript types to remove build errors. Improved accessibility for icons and added loading simulation to Builder auth forms. - **Refactors** - Replaced legacy utilities with canonical classes (e.g., bg-gradient-to-* → bg-linear-to-*, h-[1px] → h-px, min-w-[32rem] → min-w-lg, z-[1] → z-1). - Normalized arbitrary values and data attributes (e.g., data-[inset] → data-inset), updated mask/background syntax, and standardized grow/shrink utilities. - Unified CSS variable usage across components (e.g., w-(--radix-...) and h-(--radix-...)). - Removed deprecated Chart UI component. - Added simulated loading states to Builder sign-in/sign-up. - **Bug Fixes** - Fixed forwardRef typings (ComponentRef) and React component prop types to resolve TS errors. - Corrected CodeBlockTabs MDX prop handling to avoid rendering issues. - Removed unused code in sign-up and corrected minor UI issues (border, spacing, z-index, sticky/overflow). - Marked non-interactive icons as aria-hidden and added labels where needed to improve screen reader support. - Added @types/hast and @types/js-beautify to address missing types; updated lockfile accordingly. <sup>Written for commit ffd3dfcaf77dba526079c2c09530d3e085c6cd4b. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:06:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6643
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?