github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6235] [MERGED] fix: support @tanstack/solid-start in tanstackStartCookies plugin #6536

New Issue
Closed
opened 2026-03-13 13:02:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:02:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6235
Author: @jakst
Created: 11/23/2025
Status: ✅ Merged
Merged: 11/23/2025
Merged by: @Bekacru

Base: canary ← Head: patch-1

📝 Commits (3)

  • 07b41dc fix: support @tanstack/solid-start in tanstackStartCookies plugin
  • c13fbc4 Fix formatting
  • 67c6b5f Fix imports

📊 Changes

4 files changed (+13 additions, -624 deletions)

View changed files

📝 packages/better-auth/package.json (+1 -1)
📝 packages/better-auth/src/integrations/tanstack-start.ts (+1 -3)
📝 packages/better-auth/tsdown.config.ts (+1 -1)
📝 pnpm-lock.yaml (+10 -619)

📄 Description

The react specific import doesn't work with solid-start. But it's just a re-export from '@tanstack/start-server-core', so if we import directly from there instead, solid-start is automatically supported.

Summary by cubic

Fixed tanstackStartCookies to import setCookie from @tanstack/start-server-core instead of @tanstack/react-start/server. This adds support for @tanstack/solid-start and prevents import errors.

Written for commit 67c6b5f7dd. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6235 **Author:** [@jakst](https://github.com/jakst) **Created:** 11/23/2025 **Status:** ✅ Merged **Merged:** 11/23/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`07b41dc`](https://github.com/better-auth/better-auth/commit/07b41dc78bad9a1db131b6cbe9464b1f9f07fe09) fix: support @tanstack/solid-start in tanstackStartCookies plugin - [`c13fbc4`](https://github.com/better-auth/better-auth/commit/c13fbc46f8a744efa1ad8912bb14b26f6cc90909) Fix formatting - [`67c6b5f`](https://github.com/better-auth/better-auth/commit/67c6b5f7dd6dae15c85c28af37fc3ad5c1689033) Fix imports ### 📊 Changes **4 files changed** (+13 additions, -624 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/package.json` (+1 -1) 📝 `packages/better-auth/src/integrations/tanstack-start.ts` (+1 -3) 📝 `packages/better-auth/tsdown.config.ts` (+1 -1) 📝 `pnpm-lock.yaml` (+10 -619) </details> ### 📄 Description The react specific import doesn't work with solid-start. But it's just a re-export from '@tanstack/start-server-core', so if we import directly from there instead, solid-start is automatically supported. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed tanstackStartCookies to import setCookie from @tanstack/start-server-core instead of @tanstack/react-start/server. This adds support for @tanstack/solid-start and prevents import errors. <sup>Written for commit 67c6b5f7dd6dae15c85c28af37fc3ad5c1689033. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:02:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6536
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?