[PR #6156] [CLOSED] Fix/last login method passkey #6488

New Issue

GiteaMirror · 2026-03-13T13:00:59-05:00

GiteaMirror commented

2026-03-13 13:00:59 -05:00

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6156
Author: @matteobad
Created: 11/21/2025
Status: ❌ Closed

Base: canary ← Head: fix/last-login-method-passkey

📝 Commits (4)

39a81fa fix(last-login-method): add passkey as possible value
a1d04f5 fix(last-login-method): add passkey as possible value
8175a50 Merge branch 'canary' into fix/last-login-method-passkey
2d9a3f9 Merge branch 'canary' into fix/last-login-method-passkey

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/plugins/last-login-method/index.ts (+2 -0)

📄 Description

Fixes #6128

I've created this PR following the insights from the related issue and some other similar fixes.

I want to add some tests to this feature but I'm not sure on how to do it. I tried to add a test to last-login-method.test.ts but to to so I need to create a TestInstance with the passkey plugin. Problem is that the passkey plugin is in a different package and therefore cannot be used in the test file. Am I a missing something?

I'm willing to complete this PR, but I need some guidance on the preferred approach

Summary by cubic

Adds passkey support to last-login-method so passkey sign-ins are correctly recorded. The plugin now recognizes /passkey/verify-authentication and resolves "passkey" for passkey routes.

^{Written for commit 2d9a3f9921. Summary will update automatically on new commits.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6156 **Author:** [@matteobad](https://github.com/matteobad) **Created:** 11/21/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/last-login-method-passkey` --- ### 📝 Commits (4) - [`39a81fa`](https://github.com/better-auth/better-auth/commit/39a81fa133db60fca25822f90f97650ad8f3ffe3) fix(last-login-method): add passkey as possible value - [`a1d04f5`](https://github.com/better-auth/better-auth/commit/a1d04f5357adff898e379013903b84cc6dd87ff0) fix(last-login-method): add passkey as possible value - [`8175a50`](https://github.com/better-auth/better-auth/commit/8175a50fab2419edd7f18d8c17c318301b99c1f1) Merge branch 'canary' into fix/last-login-method-passkey - [`2d9a3f9`](https://github.com/better-auth/better-auth/commit/2d9a3f99210f0c69fb44d3d1fc586c871fdd26f6) Merge branch 'canary' into fix/last-login-method-passkey ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/last-login-method/index.ts` (+2 -0) </details> ### 📄 Description Fixes #6128 I've created this PR following the insights from the related issue and some other similar fixes. I want to add some tests to this feature but I'm not sure on how to do it. I tried to add a test to `last-login-method.test.ts` but to to so I need to create a `TestInstance` with the `passkey` plugin. Problem is that the `passkey` plugin is in a different package and therefore cannot be used in the test file. Am I a missing something? I'm willing to complete this PR, but I need some guidance on the preferred approach  --- ## Summary by cubic Adds passkey support to last-login-method so passkey sign-ins are correctly recorded. The plugin now recognizes /passkey/verify-authentication and resolves "passkey" for passkey routes. <sup>Written for commit 2d9a3f99210f0c69fb44d3d1fc586c871fdd26f6. Summary will update automatically on new commits.</sup>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-13 13:00:59 -05:00

GiteaMirror closed this issue