github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6121] [CLOSED] test(passkey): enhance passkey deletion tests #6462

New Issue
Closed
opened 2026-03-13 13:00:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:00:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6121
Author: @himself65
Created: 11/20/2025
Status: ❌ Closed

Base: canary ← Head: himself65/2025/11/19/passkey

📝 Commits (4)

  • f70cbac test(passkey): enhance passkey deletion tests for user ownership and existence
  • 8fae341 Update packages/passkey/src/passkey.test.ts
  • ab6f346 Update packages/passkey/src/passkey.test.ts
  • ca4e58e Update packages/passkey/src/passkey.test.ts

📊 Changes

1 file changed (+105 additions, -1 deletions)

View changed files

📝 packages/passkey/src/passkey.test.ts (+105 -1)

📄 Description

…existence

Summary by cubic

Strengthened passkey deletion tests to cover real deletion for the signed-in user, non-existent IDs, and attempts to delete another user’s passkey. Added cookie parsing to create a second user session and verified the endpoint returns null without leaking ownership or deleting the other user’s passkey.

Written for commit ca4e58e667. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6121 **Author:** [@himself65](https://github.com/himself65) **Created:** 11/20/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `himself65/2025/11/19/passkey` --- ### 📝 Commits (4) - [`f70cbac`](https://github.com/better-auth/better-auth/commit/f70cbac2695fb26d64bd40eadd89a364903a4a54) test(passkey): enhance passkey deletion tests for user ownership and existence - [`8fae341`](https://github.com/better-auth/better-auth/commit/8fae34163bc72b3795b779058e74ab2b8474effe) Update packages/passkey/src/passkey.test.ts - [`ab6f346`](https://github.com/better-auth/better-auth/commit/ab6f346aae1ff27efd8ee72ec4083897a4f75754) Update packages/passkey/src/passkey.test.ts - [`ca4e58e`](https://github.com/better-auth/better-auth/commit/ca4e58e66761e597c375f3631cb5fe54f6f101c1) Update packages/passkey/src/passkey.test.ts ### 📊 Changes **1 file changed** (+105 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/passkey/src/passkey.test.ts` (+105 -1) </details> ### 📄 Description …existence <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Strengthened passkey deletion tests to cover real deletion for the signed-in user, non-existent IDs, and attempts to delete another user’s passkey. Added cookie parsing to create a second user session and verified the endpoint returns null without leaking ownership or deleting the other user’s passkey. <sup>Written for commit ca4e58e66761e597c375f3631cb5fe54f6f101c1. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:00:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6462
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?