github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6016] [MERGED] fix(last-login-method): LastLoginMethod cookie is not set when using a generic oauth provider #6385

New Issue
Closed
opened 2026-03-13 12:57:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:57:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6016
Author: @nbifrye
Created: 11/16/2025
Status: ✅ Merged
Merged: 11/16/2025
Merged by: @Bekacru

Base: canary ← Head: fix/last-login-method-generic-oauth

📝 Commits (1)

  • 9854531 fix(last-login-method): fix genericOAuth

📊 Changes

2 files changed (+91 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/plugins/last-login-method/index.ts (+4 -2)
📝 packages/better-auth/src/plugins/last-login-method/last-login-method.test.ts (+87 -0)

📄 Description

Fixes https://github.com/better-auth/better-auth/issues/5970

Summary by cubic

Fixes last login method resolution for generic OAuth by correctly handling /oauth2/callback/:providerId so the cookie and user.lastLoginMethod are set.

  • Bug Fixes
    • Added support for providerId in /oauth2/callback paths and resolver fallback.
    • Added tests covering generic OAuth flow to verify cookie and session values.

Written for commit 985453176e. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6016 **Author:** [@nbifrye](https://github.com/nbifrye) **Created:** 11/16/2025 **Status:** ✅ Merged **Merged:** 11/16/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/last-login-method-generic-oauth` --- ### 📝 Commits (1) - [`9854531`](https://github.com/better-auth/better-auth/commit/985453176e346ef569829b3286ec015b9360d498) fix(last-login-method): fix genericOAuth ### 📊 Changes **2 files changed** (+91 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/last-login-method/index.ts` (+4 -2) 📝 `packages/better-auth/src/plugins/last-login-method/last-login-method.test.ts` (+87 -0) </details> ### 📄 Description Fixes https://github.com/better-auth/better-auth/issues/5970 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes last login method resolution for generic OAuth by correctly handling /oauth2/callback/:providerId so the cookie and user.lastLoginMethod are set. - **Bug Fixes** - Added support for providerId in /oauth2/callback paths and resolver fallback. - Added tests covering generic OAuth flow to verify cookie and session values. <sup>Written for commit 985453176e346ef569829b3286ec015b9360d498. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:57:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6385
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?