github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5966] [MERGED] fix(sso): respect disableImplicitSignUp in SAML callback #6351

New Issue
Closed
opened 2026-03-13 12:55:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:55:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5966
Author: @kanarian
Created: 11/13/2025
Status: ✅ Merged
Merged: 11/14/2025
Merged by: @himself65

Base: canary ← Head: fix/sso-saml-disable-implicit-sign-up

📝 Commits (1)

  • 9ed95e8 fix(sso): respect disableImplicitSignUp in SAML callback

📊 Changes

2 files changed (+72 additions, -0 deletions)

View changed files

📝 packages/sso/src/routes/sso.ts (+8 -0)
📝 packages/sso/src/saml.test.ts (+64 -0)

📄 Description

Addresses and closes the following issue: https://github.com/better-auth/better-auth/issues/5958

Summary by cubic

Respect disableImplicitSignUp in SAML SSO callbacks to prevent auto-creating users when they don’t exist. Returns UNAUTHORIZED with a clear message and adds test coverage.

  • Bug Fixes
    • Block user/account creation in SAML callback when disableImplicitSignUp is true and no existing user is found.
    • Added test asserting UNAUTHORIZED with “User not found and implicit sign up is disabled for this provider”.

Written for commit 9ed95e8981. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5966 **Author:** [@kanarian](https://github.com/kanarian) **Created:** 11/13/2025 **Status:** ✅ Merged **Merged:** 11/14/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/sso-saml-disable-implicit-sign-up` --- ### 📝 Commits (1) - [`9ed95e8`](https://github.com/better-auth/better-auth/commit/9ed95e8981d685b0cf649085760c957b3f49c0b5) fix(sso): respect disableImplicitSignUp in SAML callback ### 📊 Changes **2 files changed** (+72 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/routes/sso.ts` (+8 -0) 📝 `packages/sso/src/saml.test.ts` (+64 -0) </details> ### 📄 Description Addresses and closes the following issue: https://github.com/better-auth/better-auth/issues/5958 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Respect disableImplicitSignUp in SAML SSO callbacks to prevent auto-creating users when they don’t exist. Returns UNAUTHORIZED with a clear message and adds test coverage. - **Bug Fixes** - Block user/account creation in SAML callback when disableImplicitSignUp is true and no existing user is found. - Added test asserting UNAUTHORIZED with “User not found and implicit sign up is disabled for this provider”. <sup>Written for commit 9ed95e8981d685b0cf649085760c957b3f49c0b5. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:55:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6351
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?