github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5918] [MERGED] test: fix node.js 25 compatibility #6321

New Issue
Closed
opened 2026-03-13 12:54:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:54:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5918
Author: @himself65
Created: 11/11/2025
Status: ✅ Merged
Merged: 11/12/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/11/11/node25

📝 Commits (5)

📊 Changes

6 files changed (+198 additions, -113 deletions)

View changed files

📝 packages/better-auth/package.json (+1 -1)
📝 packages/better-auth/vitest.config.ts (+0 -1)
➖ packages/better-auth/vitest.setup.ts (+0 -7)
➕ patches/msw.patch (+85 -0)
📝 pnpm-lock.yaml (+109 -104)
📝 pnpm-workspace.yaml (+3 -0)

📄 Description

Related: https://github.com/nodejs/node/releases/tag/v25.2.0
Upstream: https://github.com/nodejs/node/pull/60351

Summary by cubic

Fix Vitest on Node.js 25 by removing the setup that unsets globalThis.localStorage, and bumping/patching MSW to avoid localStorage usage in Node. Tests now run on Node 25’s default environment without overrides.

Written for commit dc24624b11. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5918 **Author:** [@himself65](https://github.com/himself65) **Created:** 11/11/2025 **Status:** ✅ Merged **Merged:** 11/12/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/11/11/node25` --- ### 📝 Commits (5) - [`bc505c0`](https://github.com/better-auth/better-auth/commit/bc505c0bb56b2ddab823eebf29ee890be047af20) test: fix node.js 25 compatibility - [`c8a07e1`](https://github.com/better-auth/better-auth/commit/c8a07e1fa5b0459e3e682689bee15ef26a448274) chore: bump - [`9b02a5e`](https://github.com/better-auth/better-auth/commit/9b02a5eaeaf06a8856224c8b37c4a37cc07b752c) fix: patch - [`7a26004`](https://github.com/better-auth/better-auth/commit/7a260042e92627e4c2b020314d0a4c51ff4ac9c1) feat: update patch - [`dc24624`](https://github.com/better-auth/better-auth/commit/dc24624b11ec42b52f34efccf65df201699ad421) feat: update patch ### 📊 Changes **6 files changed** (+198 additions, -113 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/package.json` (+1 -1) 📝 `packages/better-auth/vitest.config.ts` (+0 -1) ➖ `packages/better-auth/vitest.setup.ts` (+0 -7) ➕ `patches/msw.patch` (+85 -0) 📝 `pnpm-lock.yaml` (+109 -104) 📝 `pnpm-workspace.yaml` (+3 -0) </details> ### 📄 Description Related: https://github.com/nodejs/node/releases/tag/v25.2.0 Upstream: https://github.com/nodejs/node/pull/60351 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix Vitest on Node.js 25 by removing the setup that unsets globalThis.localStorage, and bumping/patching MSW to avoid localStorage usage in Node. Tests now run on Node 25’s default environment without overrides. <sup>Written for commit dc24624b11ec42b52f34efccf65df201699ad421. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:54:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6321
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?