github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5898] [MERGED] test: no hanging promise #6306

New Issue
Closed
opened 2026-03-13 12:54:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:54:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5898
Author: @himself65
Created: 11/11/2025
Status: ✅ Merged
Merged: 11/11/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/11/10/test

📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/organization/organization.test.ts (+1 -1)

📄 Description

Fixes: https://github.com/better-auth/better-auth/actions/runs/19255020378/job/55047819906?pr=5891

Summary by cubic

Added await to auth.api.setActiveOrganization in organization.test to prevent a hanging promise. Stabilizes the “get active member” test and fixes the failing CI run.

Written for commit 9a2bae590f. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5898 **Author:** [@himself65](https://github.com/himself65) **Created:** 11/11/2025 **Status:** ✅ Merged **Merged:** 11/11/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/11/10/test` --- ### 📝 Commits (1) - [`9a2bae5`](https://github.com/better-auth/better-auth/commit/9a2bae590f30346e514981814da0a68b05c7d33f) test: no hanging promise ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/organization/organization.test.ts` (+1 -1) </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/actions/runs/19255020378/job/55047819906?pr=5891 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Added await to auth.api.setActiveOrganization in organization.test to prevent a hanging promise. Stabilizes the “get active member” test and fixes the failing CI run. <sup>Written for commit 9a2bae590f30346e514981814da0a68b05c7d33f. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:54:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?