github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5820] [MERGED] chore: use const tokenEndpoint declarations in social providers #6250

New Issue
Closed
opened 2026-03-13 12:52:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:52:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5820
Author: @lakbychance
Created: 11/7/2025
Status: ✅ Merged
Merged: 3/4/2026
Merged by: @himself65

Base: canary ← Head: remove-duplicate-tokenEndpoint-declarations

📝 Commits (6)

  • 7c629eb use const tokenEndpoint declarations in social providers
  • 84f5b4d Merge branch 'canary' into remove-duplicate-tokenEndpoint-declarations
  • 285e84e lint fix
  • 260e99c Merge branch 'remove-duplicate-tokenEndpoint-declarations' of github.com:lakbychance/better-auth into remove-duplicate-tokenEndpoint-declarations
  • 548b881 Merge branch 'canary' into remove-duplicate-tokenEndpoint-declarations
  • d0e693d Merge branch 'canary' into remove-duplicate-tokenEndpoint-declarations

📊 Changes

16 files changed (+44 additions, -30 deletions)

View changed files

📝 packages/core/src/social-providers/apple.ts (+1 -1)
📝 packages/core/src/social-providers/atlassian.ts (+3 -2)
📝 packages/core/src/social-providers/discord.ts (+3 -2)
📝 packages/core/src/social-providers/figma.ts (+3 -2)
📝 packages/core/src/social-providers/github.ts (+1 -1)
📝 packages/core/src/social-providers/huggingface.ts (+3 -2)
📝 packages/core/src/social-providers/kakao.ts (+3 -2)
📝 packages/core/src/social-providers/naver.ts (+3 -2)
📝 packages/core/src/social-providers/polar.ts (+3 -2)
📝 packages/core/src/social-providers/roblox.ts (+3 -2)
📝 packages/core/src/social-providers/slack.ts (+3 -2)
📝 packages/core/src/social-providers/spotify.ts (+3 -2)
📝 packages/core/src/social-providers/tiktok.ts (+3 -2)
📝 packages/core/src/social-providers/twitch.ts (+3 -2)
📝 packages/core/src/social-providers/twitter.ts (+3 -2)
📝 packages/core/src/social-providers/vk.ts (+3 -2)

📄 Description

Noticed that in some social-providers, we reuse the same const tokenEndpoint declarations while in others we don't. This PR aims to remove that redundancy wherever applicable i.e. where validateAuthorizationCode and refreshAccessToken use the same tokenEndpoint.

Summary by cubic

Consolidated tokenEndpoint declarations in social providers by defining a single const per provider when both authorization and refresh use the same endpoint. This removes duplication and keeps endpoints consistent with no behavior changes.

  • Refactors
    • Replaced inline tokenEndpoint strings with a const in: Apple, Atlassian, Discord, Figma, GitHub, Hugging Face, Kakao, Naver, Polar, Roblox, Slack, Spotify, TikTok, Twitch, Twitter (X), VK.
    • Re-synced with latest canary; cleanup only, no API or functional changes.

Written for commit d0e693dab0. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5820 **Author:** [@lakbychance](https://github.com/lakbychance) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 3/4/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `remove-duplicate-tokenEndpoint-declarations` --- ### 📝 Commits (6) - [`7c629eb`](https://github.com/better-auth/better-auth/commit/7c629ebbef113f2724b83d7f9902c42ca71cb6e4) use const tokenEndpoint declarations in social providers - [`84f5b4d`](https://github.com/better-auth/better-auth/commit/84f5b4d98ec7144d6150c6901533a483c86c5cfc) Merge branch 'canary' into remove-duplicate-tokenEndpoint-declarations - [`285e84e`](https://github.com/better-auth/better-auth/commit/285e84ead448c7406ce11b3369d6df8d4e96f898) lint fix - [`260e99c`](https://github.com/better-auth/better-auth/commit/260e99ce60b504d94be50eace1595f872a088786) Merge branch 'remove-duplicate-tokenEndpoint-declarations' of github.com:lakbychance/better-auth into remove-duplicate-tokenEndpoint-declarations - [`548b881`](https://github.com/better-auth/better-auth/commit/548b88158c8fc48469cf699e10a2ef0b342f4812) Merge branch 'canary' into remove-duplicate-tokenEndpoint-declarations - [`d0e693d`](https://github.com/better-auth/better-auth/commit/d0e693dab07968fb7054d56be11d5345d7b4f10c) Merge branch 'canary' into remove-duplicate-tokenEndpoint-declarations ### 📊 Changes **16 files changed** (+44 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/social-providers/apple.ts` (+1 -1) 📝 `packages/core/src/social-providers/atlassian.ts` (+3 -2) 📝 `packages/core/src/social-providers/discord.ts` (+3 -2) 📝 `packages/core/src/social-providers/figma.ts` (+3 -2) 📝 `packages/core/src/social-providers/github.ts` (+1 -1) 📝 `packages/core/src/social-providers/huggingface.ts` (+3 -2) 📝 `packages/core/src/social-providers/kakao.ts` (+3 -2) 📝 `packages/core/src/social-providers/naver.ts` (+3 -2) 📝 `packages/core/src/social-providers/polar.ts` (+3 -2) 📝 `packages/core/src/social-providers/roblox.ts` (+3 -2) 📝 `packages/core/src/social-providers/slack.ts` (+3 -2) 📝 `packages/core/src/social-providers/spotify.ts` (+3 -2) 📝 `packages/core/src/social-providers/tiktok.ts` (+3 -2) 📝 `packages/core/src/social-providers/twitch.ts` (+3 -2) 📝 `packages/core/src/social-providers/twitter.ts` (+3 -2) 📝 `packages/core/src/social-providers/vk.ts` (+3 -2) </details> ### 📄 Description Noticed that in some social-providers, we reuse the same `const tokenEndpoint` declarations while in others we don't. This PR aims to remove that redundancy wherever applicable i.e. where `validateAuthorizationCode` and `refreshAccessToken` use the same `tokenEndpoint`. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Consolidated tokenEndpoint declarations in social providers by defining a single const per provider when both authorization and refresh use the same endpoint. This removes duplication and keeps endpoints consistent with no behavior changes. - **Refactors** - Replaced inline tokenEndpoint strings with a const in: Apple, Atlassian, Discord, Figma, GitHub, Hugging Face, Kakao, Naver, Polar, Roblox, Slack, Spotify, TikTok, Twitch, Twitter (X), VK. - Re-synced with latest canary; cleanup only, no API or functional changes. <sup>Written for commit d0e693dab07968fb7054d56be11d5345d7b4f10c. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:52:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6250
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?