github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5681] [CLOSED] fix(generic-oauth): async mapProfileToUser breaks #6154

New Issue
Closed
opened 2026-03-13 12:49:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:49:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5681
Author: @ping-maxwell
Created: 10/30/2025
Status: ❌ Closed

Base: canary ← Head: fix/generic-oauth-mapProfileToUser-with-async-breaks

📝 Commits (1)

  • 3c2959e fix(generic-oauth): async mapProfileToUser breaks

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/generic-oauth/index.ts (+1 -1)

📄 Description

After debugging for an unacceptable amount of time, I found out that our generic oauth plugin with mapProfileToUser breaks when users apply async to their function despite our function signature supporting this. It breaks because we didn't use await...

Thanks so much @michidk for patiently debugging alongside me!

closes https://github.com/better-auth/better-auth/pull/5681
linear https://linear.app/better-auth/issue/ENG-547/fix-generic-oauth-breaks-entirely-with-async-mapprofiletouser

Summary by cubic

Fixes the generic OAuth plugin to correctly handle async mapProfileToUser by awaiting its result when constructing the user object. Prevents auth flow from breaking when mapProfileToUser returns a Promise.

  • Bug Fixes
    • Await mapProfileToUser(userInfo) so async implementations are supported.
    • Ensures mapped fields merge correctly into the user payload.

Written for commit 3c2959e. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5681 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 10/30/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/generic-oauth-mapProfileToUser-with-async-breaks` --- ### 📝 Commits (1) - [`3c2959e`](https://github.com/better-auth/better-auth/commit/3c2959e9854e27835667ce55fc4705145b771687) fix(generic-oauth): async `mapProfileToUser` breaks ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/generic-oauth/index.ts` (+1 -1) </details> ### 📄 Description After debugging for an unacceptable amount of time, I found out that our generic oauth plugin with `mapProfileToUser` breaks when users apply `async` to their function despite our function signature supporting this. It breaks because we didn't use `await`... Thanks so much @michidk for patiently debugging alongside me! closes https://github.com/better-auth/better-auth/pull/5681 linear https://linear.app/better-auth/issue/ENG-547/fix-generic-oauth-breaks-entirely-with-async-mapprofiletouser <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes the generic OAuth plugin to correctly handle async mapProfileToUser by awaiting its result when constructing the user object. Prevents auth flow from breaking when mapProfileToUser returns a Promise. - **Bug Fixes** - Await mapProfileToUser(userInfo) so async implementations are supported. - Ensures mapped fields merge correctly into the user payload. <sup>Written for commit 3c2959e. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:49:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?