github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-22 16:42:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5434] [MERGED] test: username type infer #6006

New Issue
Closed
opened 2026-03-13 12:44:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:44:24 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5434
Author: @himself65
Created: 10/20/2025
Status: ✅ Merged
Merged: 10/20/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/10/20/type

📝 Commits (1)

  • 3b92b85 test: username type infer

📊 Changes

2 files changed (+30 additions, -1 deletions)

View changed files

➕ e2e/smoke/test/fixtures/tsconfig-declaration/src/username.ts (+28 -0)
📝 packages/better-auth/src/plugins/username/index.ts (+2 -1)

📄 Description

Summary by cubic

Added an e2e fixture that asserts the inferred Session.user type when the username plugin is enabled. Updated plugin imports to use core DB types so username fields are typed correctly.

  • Refactors
    • Use Account and User from @better-auth/core/db.
    • Import InferOptionSchema from ../../types/plugins.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5434 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/20/2025 **Status:** ✅ Merged **Merged:** 10/20/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/10/20/type` --- ### 📝 Commits (1) - [`3b92b85`](https://github.com/better-auth/better-auth/commit/3b92b852d608f0fcc501d5c727f5cb9e95022f12) test: username type infer ### 📊 Changes **2 files changed** (+30 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `e2e/smoke/test/fixtures/tsconfig-declaration/src/username.ts` (+28 -0) 📝 `packages/better-auth/src/plugins/username/index.ts` (+2 -1) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Added an e2e fixture that asserts the inferred Session.user type when the username plugin is enabled. Updated plugin imports to use core DB types so username fields are typed correctly. - **Refactors** - Use Account and User from @better-auth/core/db. - Import InferOptionSchema from ../../types/plugins. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:44:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6006