github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5395] [MERGED] chore: remove process.platform check #5978

New Issue
Closed
opened 2026-03-13 12:43:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:43:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5395
Author: @himself65
Created: 10/17/2025
Status: ✅ Merged
Merged: 10/17/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/10/17/remove-process-check

📝 Commits (1)

  • d8a1446 chore: remove process.platform check

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 packages/core/src/env/color-depth.ts (+5 -4)

📄 Description

@better-auth/demo:build: > Build error occurred
@better-auth/demo:build: Error: Turbopack build failed with 1 errors:
@better-auth/demo:build: ./packages/core/dist/env-rsIfwYOu.js:138:40
@better-auth/demo:build: Ecmascript file had an error
@better-auth/demo:build:   136 | 	}
@better-auth/demo:build:   137 | 	if (getEnvVar("NODE_DISABLE_COLORS") !== void 0 && getEnvVar("NODE_DISABLE_COLORS") !== "" || getEnvVar("NO_COLOR") !== void 0 && getEnvVar("NO_COLOR") !== "" || getEnvVar("TERM") === "dumb") return COLORS_2;
@better-auth/demo:build: > 138 | 	if (typeof process !== "undefined" && process?.platform === "win32") return COLORS_16m;
@better-auth/demo:build:       | 	                                      ^^^^^^^^^^^^^^^^^
@better-auth/demo:build:   139 | 	if (getEnvVar("TMUX")) return COLORS_16m;
@better-auth/demo:build:   140 | 	if ("TF_BUILD" in env && "AGENT_NAME" in env) return COLORS_16;
@better-auth/demo:build:   141 | 	if ("CI" in env) {
@better-auth/demo:build: 
@better-auth/demo:build: A Node.js API is used (process.platform at line: 138) which is not supported in the Edge Runtime.
@better-auth/demo:build: Learn more: https://nextjs.org/docs/api-reference/edge-runtime
@better-auth/demo:build:

Summary by cubic

Removed the process.platform check in getColorDepth to fix Edge runtime build failures. This avoids Node-only APIs so the demo builds and runs with Next.js Turbopack on Edge.

  • Bug Fixes
    • Removed process.platform usage; Windows-specific true color path disabled.
    • Unblocks Edge runtime builds.
    • Color depth detection now relies only on env vars (TMUX, CI, TERM, etc.).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5395 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/17/2025 **Status:** ✅ Merged **Merged:** 10/17/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/10/17/remove-process-check` --- ### 📝 Commits (1) - [`d8a1446`](https://github.com/better-auth/better-auth/commit/d8a1446dcdcca1cd9dece5e293f8c7b94545b38f) chore: remove process.platform check ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/env/color-depth.ts` (+5 -4) </details> ### 📄 Description ``` @better-auth/demo:build: > Build error occurred @better-auth/demo:build: Error: Turbopack build failed with 1 errors: @better-auth/demo:build: ./packages/core/dist/env-rsIfwYOu.js:138:40 @better-auth/demo:build: Ecmascript file had an error @better-auth/demo:build: 136 | } @better-auth/demo:build: 137 | if (getEnvVar("NODE_DISABLE_COLORS") !== void 0 && getEnvVar("NODE_DISABLE_COLORS") !== "" || getEnvVar("NO_COLOR") !== void 0 && getEnvVar("NO_COLOR") !== "" || getEnvVar("TERM") === "dumb") return COLORS_2; @better-auth/demo:build: > 138 | if (typeof process !== "undefined" && process?.platform === "win32") return COLORS_16m; @better-auth/demo:build: | ^^^^^^^^^^^^^^^^^ @better-auth/demo:build: 139 | if (getEnvVar("TMUX")) return COLORS_16m; @better-auth/demo:build: 140 | if ("TF_BUILD" in env && "AGENT_NAME" in env) return COLORS_16; @better-auth/demo:build: 141 | if ("CI" in env) { @better-auth/demo:build: @better-auth/demo:build: A Node.js API is used (process.platform at line: 138) which is not supported in the Edge Runtime. @better-auth/demo:build: Learn more: https://nextjs.org/docs/api-reference/edge-runtime @better-auth/demo:build: ``` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removed the process.platform check in getColorDepth to fix Edge runtime build failures. This avoids Node-only APIs so the demo builds and runs with Next.js Turbopack on Edge. - **Bug Fixes** - Removed process.platform usage; Windows-specific true color path disabled. - Unblocks Edge runtime builds. - Color depth detection now relies only on env vars (TMUX, CI, TERM, etc.). <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:43:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5978
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?