github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5394] [MERGED] test: fix issue with msw #5977

New Issue
Closed
opened 2026-03-13 12:43:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:43:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5394
Author: @himself65
Created: 10/17/2025
Status: ✅ Merged
Merged: 10/17/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/10/17/fix

📝 Commits (1)

📊 Changes

2 files changed (+8 additions, -0 deletions)

View changed files

📝 packages/better-auth/vitest.config.ts (+1 -0)
➕ packages/better-auth/vitest.setup.ts (+7 -0)

📄 Description

Fixes: https://github.com/mswjs/msw/issues/2612

Summary by cubic

Fix MSW tests failing on Node 25 by disabling global localStorage in Vitest setup. Ensures a consistent Node-only environment during tests.

  • Bug Fixes
    • Added vitest.setup.ts to unset globalThis.localStorage when Node >= 25.
    • Registered the setup file in vitest.config.ts via test.setupFiles.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5394 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/17/2025 **Status:** ✅ Merged **Merged:** 10/17/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/10/17/fix` --- ### 📝 Commits (1) - [`95a3102`](https://github.com/better-auth/better-auth/commit/95a31025d293359d8b3c3d235c22adafdd5d707f) test: fix issue with msw ### 📊 Changes **2 files changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/vitest.config.ts` (+1 -0) ➕ `packages/better-auth/vitest.setup.ts` (+7 -0) </details> ### 📄 Description Fixes: https://github.com/mswjs/msw/issues/2612 <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fix MSW tests failing on Node 25 by disabling global localStorage in Vitest setup. Ensures a consistent Node-only environment during tests. - **Bug Fixes** - Added vitest.setup.ts to unset globalThis.localStorage when Node >= 25. - Registered the setup file in vitest.config.ts via test.setupFiles. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:43:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5977
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?