github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5325] [MERGED] fix(api-key): remove incorrect usage tracking in updateApiKey #5929

New Issue
Closed
opened 2026-03-13 12:41:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:41:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5325
Author: @ahmed-abdat
Created: 10/15/2025
Status: ✅ Merged
Merged: 10/17/2025
Merged by: @Bekacru

Base: canary ← Head: fix/api-key-lastrequest-bug

📝 Commits (3)

  • 5fb39dd fix(api-key): remove incorrect usage tracking in updateApiKey
  • 7e60bf9 test(api-key): remove inline comments to match repository patterns
  • 275b0d9 Merge branch 'canary' into fix/api-key-lastrequest-bug

📊 Changes

2 files changed (+103 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/api-key/api-key.test.ts (+103 -0)
📝 packages/better-auth/src/plugins/api-key/routes/update-api-key.ts (+0 -1)

📄 Description

Fixes #5309

Problem

The updateApiKey endpoint incorrectly updates lastRequest timestamp and auto-decrements remaining counter on every configuration update, conflating management operations with actual API key usage.

Solution

Removed lines that unconditionally set lastRequest and auto-decrement remaining from updateApiKey. These fields should only be modified during actual API key usage (verifyApiKey), not during configuration updates.

Tests

  • updateApiKey does not modify lastRequest
  • updateApiKey does not auto-decrement remaining
  • Explicit remaining updates still work
  • verifyApiKey still correctly tracks usage (regression)
  • All existing tests pass

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5325 **Author:** [@ahmed-abdat](https://github.com/ahmed-abdat) **Created:** 10/15/2025 **Status:** ✅ Merged **Merged:** 10/17/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/api-key-lastrequest-bug` --- ### 📝 Commits (3) - [`5fb39dd`](https://github.com/better-auth/better-auth/commit/5fb39ddf726c80e7b1fb8ee51850ddfbcac2dc05) fix(api-key): remove incorrect usage tracking in updateApiKey - [`7e60bf9`](https://github.com/better-auth/better-auth/commit/7e60bf9d671cb05f01f61c6737415e1e7a4fb002) test(api-key): remove inline comments to match repository patterns - [`275b0d9`](https://github.com/better-auth/better-auth/commit/275b0d9f4ea50c603ccd19bebf4edf1f273caa17) Merge branch 'canary' into fix/api-key-lastrequest-bug ### 📊 Changes **2 files changed** (+103 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/api-key/api-key.test.ts` (+103 -0) 📝 `packages/better-auth/src/plugins/api-key/routes/update-api-key.ts` (+0 -1) </details> ### 📄 Description Fixes #5309 ### Problem The `updateApiKey` endpoint incorrectly updates `lastRequest` timestamp and auto-decrements `remaining` counter on every configuration update, conflating management operations with actual API key usage. ### Solution Removed lines that unconditionally set `lastRequest` and auto-decrement `remaining` from updateApiKey. These fields should only be modified during actual API key usage (verifyApiKey), not during configuration updates. ### Tests - [x] updateApiKey does not modify lastRequest - [x] updateApiKey does not auto-decrement remaining - [x] Explicit remaining updates still work - [x] verifyApiKey still correctly tracks usage (regression) - [x] All existing tests pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:41:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5929
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?