github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-15 08:25:06 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5324] [MERGED] docs: Improve cookie information in docs #5928

New Issue
Closed
opened 2026-03-13 12:41:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:41:38 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5324
Author: @ping-maxwell
Created: 10/15/2025
Status: ✅ Merged
Merged: 11/6/2025
Merged by: @himself65

Base: canary ← Head: docs/improve-cookie-docs-info

📝 Commits (10+)

  • f7c5944 docs: Improve cookie information in docs
  • c719469 Update docs/content/docs/concepts/cookies.mdx
  • cff6947 Merge branch 'canary' into docs/improve-cookie-docs-info
  • bd0e815 fix: rearrange order
  • d6c3ece Merge branch 'canary' into docs/improve-cookie-docs-info
  • a4e9221 Merge branch 'canary' into docs/improve-cookie-docs-info
  • 99ee533 Merge branch 'canary' into docs/improve-cookie-docs-info
  • f7bffaa Merge branch 'canary' into docs/improve-cookie-docs-info
  • 77653b0 Merge branch 'canary' into docs/improve-cookie-docs-info
  • fbf4ac2 Merge branch 'canary' into docs/improve-cookie-docs-info

📊 Changes

1 file changed (+11 additions, -1 deletions)

View changed files

📝 docs/content/docs/concepts/cookies.mdx (+11 -1)

📄 Description

Documents that cookies won't save when sent from a different origin due to CORS. It may be obvious but I've seen some cases where people are not happy we didn't document it.

linear: https://linear.app/better-auth/issue/ENG-391/docs-improve-cookie-documentation-regarding-domains

Summary by cubic

Clarified that cookies only work on the same domain and won’t be sent across different origins. Also documented that cookies are signed with the auth secret or BETTER_AUTH_SECRET and added a link to cross‑subdomain cookies; addresses Linear ENG‑391.

Written for commit 5de8f5b930. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5324 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 10/15/2025 **Status:** ✅ Merged **Merged:** 11/6/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `docs/improve-cookie-docs-info` --- ### 📝 Commits (10+) - [`f7c5944`](https://github.com/better-auth/better-auth/commit/f7c594490c2485770c78763a56d25f9939d5ace8) docs: Improve cookie information in docs - [`c719469`](https://github.com/better-auth/better-auth/commit/c7194694583ead497911803d6297d1afad143da1) Update docs/content/docs/concepts/cookies.mdx - [`cff6947`](https://github.com/better-auth/better-auth/commit/cff6947c024b30feed4fc7cff44aed43dc3f8e02) Merge branch 'canary' into docs/improve-cookie-docs-info - [`bd0e815`](https://github.com/better-auth/better-auth/commit/bd0e8157620b5d4b924a25dc839a8aa6d195611a) fix: rearrange order - [`d6c3ece`](https://github.com/better-auth/better-auth/commit/d6c3ece6763abadcec5c20d9bd5846c70de0e160) Merge branch 'canary' into docs/improve-cookie-docs-info - [`a4e9221`](https://github.com/better-auth/better-auth/commit/a4e9221f08fca92224c33030d01493993e412b0c) Merge branch 'canary' into docs/improve-cookie-docs-info - [`99ee533`](https://github.com/better-auth/better-auth/commit/99ee5337344864de636344ea69f83883d1f40437) Merge branch 'canary' into docs/improve-cookie-docs-info - [`f7bffaa`](https://github.com/better-auth/better-auth/commit/f7bffaa2450bd474e2e465456e066e963fa5500d) Merge branch 'canary' into docs/improve-cookie-docs-info - [`77653b0`](https://github.com/better-auth/better-auth/commit/77653b0a868a825211bf9094952cef6809393783) Merge branch 'canary' into docs/improve-cookie-docs-info - [`fbf4ac2`](https://github.com/better-auth/better-auth/commit/fbf4ac267570afdb7c7e400dc9a3ffee5d9456a6) Merge branch 'canary' into docs/improve-cookie-docs-info ### 📊 Changes **1 file changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/concepts/cookies.mdx` (+11 -1) </details> ### 📄 Description Documents that cookies won't save when sent from a different origin due to CORS. It may be obvious but I've seen some cases where people are not happy we didn't document it. linear: https://linear.app/better-auth/issue/ENG-391/docs-improve-cookie-documentation-regarding-domains <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Clarified that cookies only work on the same domain and won’t be sent across different origins. Also documented that cookies are signed with the auth secret or BETTER_AUTH_SECRET and added a link to cross‑subdomain cookies; addresses Linear ENG‑391. <sup>Written for commit 5de8f5b930623683f892439e1b1298baa9f591c8. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:41:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5928