github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5194] [MERGED] chore(telemetry): misc update #5839

New Issue
Closed
opened 2026-03-13 12:38:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:38:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5194
Author: @himself65
Created: 10/9/2025
Status: ✅ Merged
Merged: 10/9/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/10/09/type

📝 Commits (7)

📊 Changes

7 files changed (+420 additions, -128 deletions)

View changed files

➖ packages/telemetry/build.config.ts (+0 -10)
📝 packages/telemetry/package.json (+7 -5)
📝 packages/telemetry/src/detectors/detect-auth-config.ts (+4 -2)
📝 packages/telemetry/src/index.ts (+13 -19)
📝 packages/telemetry/src/types.ts (+0 -26)
➕ packages/telemetry/tsdown.config.ts (+7 -0)
📝 pnpm-lock.yaml (+389 -66)

📄 Description

Summary by cubic

Telemetry now uses BetterAuthOptions from @better-auth/core instead of a local shim. This removes duplicate types and keeps telemetry aligned with core.

  • Refactors

    • Replaced local BetterAuthOptions with the core type; removed redundant types and index re-exports.
    • No runtime changes.

  • Migration

    • Import BetterAuthOptions from @better-auth/core.
    • Import getTelemetryAuthConfig directly from detectors/detect-auth-config (not from the telemetry index).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5194 **Author:** [@himself65](https://github.com/himself65) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 10/9/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/10/09/type` --- ### 📝 Commits (7) - [`2cd28ab`](https://github.com/better-auth/better-auth/commit/2cd28ab20a16485d26095253ed34b204208ed755) fix(telemetry): reuse type from core - [`ffc4ccf`](https://github.com/better-auth/better-auth/commit/ffc4ccfcea5c84397b9a01a626d0540f6c9b02f3) fix: config - [`f0f7fab`](https://github.com/better-auth/better-auth/commit/f0f7fab5a19f095825507f99fcf8b1ae3fe1ba83) fix: type - [`ea99e8e`](https://github.com/better-auth/better-auth/commit/ea99e8ebd74768295269b0213fdccb63a844430f) chore: deps - [`d9797ee`](https://github.com/better-auth/better-auth/commit/d9797ee7c43db2e6749f2e32860cf8e4cf4ca7f3) chore: use tsdown - [`351615e`](https://github.com/better-auth/better-auth/commit/351615e39efe4459c7c116929dc08357f4a489b4) chore: deps - [`1edf95e`](https://github.com/better-auth/better-auth/commit/1edf95edb9aa13c7e7f6693d99f0cd03dda67a69) fix: type ### 📊 Changes **7 files changed** (+420 additions, -128 deletions) <details> <summary>View changed files</summary> ➖ `packages/telemetry/build.config.ts` (+0 -10) 📝 `packages/telemetry/package.json` (+7 -5) 📝 `packages/telemetry/src/detectors/detect-auth-config.ts` (+4 -2) 📝 `packages/telemetry/src/index.ts` (+13 -19) 📝 `packages/telemetry/src/types.ts` (+0 -26) ➕ `packages/telemetry/tsdown.config.ts` (+7 -0) 📝 `pnpm-lock.yaml` (+389 -66) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Telemetry now uses BetterAuthOptions from @better-auth/core instead of a local shim. This removes duplicate types and keeps telemetry aligned with core. - **Refactors** - Replaced local BetterAuthOptions with the core type; removed redundant types and index re-exports. - No runtime changes. - **Migration** - Import BetterAuthOptions from @better-auth/core. - Import getTelemetryAuthConfig directly from detectors/detect-auth-config (not from the telemetry index). <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:38:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5839
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?