github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Update middleware docs to use cookies for protected routes #579

New Issue
Closed
opened 2026-03-13 07:54:34 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-03-13 07:54:34 -05:00
Owner
Copy Link

Originally created by @daveycodez on GitHub (Jan 21, 2025).

Describe the solution you'd like

According to Next.js head of developer relations (https://www.youtube.com/watch?si=_rgPzz8PHodJpQjO&t=682&v=N_sUsq_y10U&feature=youtu.be) it is against best practices to perform any UI blocking or HTTP requests in middleware, and middleware should be used for optimistic routing whereas the actual route protection should happen on the route itself.

Describe alternatives you've considered

Use cookies

const protectedRoutes: string[] = ["/dashboard"]

export async function middleware(request: NextRequest) {
    if (protectedRoutes.includes(request.nextUrl.pathname)) {
        if (!request.cookies.has("better-auth.session_token")) {
            return NextResponse.redirect(new URL("/", request.url))
        }
    }

   return NextResponse.next()
}

It would be great to have better-auth auth.ts export a hasCookie function that checks for cookies so we don't have to hardcode the cookie name here.

Also something like getCookieSession that optimistically verifies session_data cookie and returns it, no HTTP requests or DB queries.

Originally created by @daveycodez on GitHub (Jan 21, 2025). ### Describe the solution you'd like According to Next.js head of developer relations (https://www.youtube.com/watch?si=_rgPzz8PHodJpQjO&t=682&v=N_sUsq_y10U&feature=youtu.be) it is against best practices to perform any UI blocking or HTTP requests in middleware, and middleware should be used for optimistic routing whereas the actual route protection should happen on the route itself. ### Describe alternatives you've considered Use cookies ```ts const protectedRoutes: string[] = ["/dashboard"] export async function middleware(request: NextRequest) { if (protectedRoutes.includes(request.nextUrl.pathname)) { if (!request.cookies.has("better-auth.session_token")) { return NextResponse.redirect(new URL("/", request.url)) } } return NextResponse.next() } ``` It would be great to have better-auth auth.ts export a hasCookie function that checks for cookies so we don't have to hardcode the cookie name here. Also something like getCookieSession that optimistically verifies session_data cookie and returns it, no HTTP requests or DB queries.
GiteaMirror commented 2026-03-13 07:54:35 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Jan 22, 2025):

good suggestion

@Bekacru commented on GitHub (Jan 22, 2025): good suggestion
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#579
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?