github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5080] [MERGED] chore: add more adapter tests #5760

New Issue
Closed
opened 2026-03-13 12:34:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:34:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5080
Author: @ping-maxwell
Created: 10/4/2025
Status: ✅ Merged
Merged: 10/5/2025
Merged by: @ping-maxwell

Base: canary ← Head: update/add-more-adapter-tests

📝 Commits (4)

  • 19d8815 chore: add more adapter tests
  • fdcc851 Merge branch 'canary' into update/add-more-adapter-tests
  • 976c668 fix: type issues
  • c28d590 Merge branch 'canary' into update/add-more-adapter-tests

📊 Changes

5 files changed (+60 additions, -15 deletions)

View changed files

📝 packages/better-auth/src/adapters/adapter-factory/index.ts (+8 -1)
📝 packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.mysql.test.ts (+0 -6)
📝 packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.mysql.test.ts (+0 -6)
📝 packages/better-auth/src/adapters/memory-adapter/adapter.memory.test.ts (+4 -2)
📝 packages/better-auth/src/adapters/tests/normal.ts (+48 -0)

📄 Description

more unit tests for adapters.

Summary by cubic

Expanded adapter test coverage to handle custom model names and additional fields, and fixed model-name normalization across adapter CRUD methods. Memory adapter migrations now respect mapped model names, and MySQL adapter tests no longer assume fixed table names.

  • Bug Fixes
    • Normalize model names with getDefaultModelName in create, updateMany, findOne, findMany, delete, deleteMany, and count.
    • Memory adapter uses authTables.modelName when initializing tables.
    • Removed rigid table-name assertions in MySQL adapter tests to support custom schemas.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5080 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 10/4/2025 **Status:** ✅ Merged **Merged:** 10/5/2025 **Merged by:** [@ping-maxwell](https://github.com/ping-maxwell) **Base:** `canary` ← **Head:** `update/add-more-adapter-tests` --- ### 📝 Commits (4) - [`19d8815`](https://github.com/better-auth/better-auth/commit/19d881596756ca797336251b46919896df1942a6) chore: add more adapter tests - [`fdcc851`](https://github.com/better-auth/better-auth/commit/fdcc8519d9a6865707f1134b699e07e094e1745e) Merge branch 'canary' into update/add-more-adapter-tests - [`976c668`](https://github.com/better-auth/better-auth/commit/976c668ed4f0a1996ed8f87461b660016d8c0531) fix: type issues - [`c28d590`](https://github.com/better-auth/better-auth/commit/c28d5905bd773c93b9faeef1c6371a3a8afc7b16) Merge branch 'canary' into update/add-more-adapter-tests ### 📊 Changes **5 files changed** (+60 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/adapter-factory/index.ts` (+8 -1) 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.mysql.test.ts` (+0 -6) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysely.mysql.test.ts` (+0 -6) 📝 `packages/better-auth/src/adapters/memory-adapter/adapter.memory.test.ts` (+4 -2) 📝 `packages/better-auth/src/adapters/tests/normal.ts` (+48 -0) </details> ### 📄 Description more unit tests for adapters. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Expanded adapter test coverage to handle custom model names and additional fields, and fixed model-name normalization across adapter CRUD methods. Memory adapter migrations now respect mapped model names, and MySQL adapter tests no longer assume fixed table names. - **Bug Fixes** - Normalize model names with getDefaultModelName in create, updateMany, findOne, findMany, delete, deleteMany, and count. - Memory adapter uses authTables.modelName when initializing tables. - Removed rigid table-name assertions in MySQL adapter tests to support custom schemas. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:34:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5760
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?