github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #5061] [MERGED] fix(organization): removeTeamMember breaks for prisma #5748

New Issue
Closed
opened 2026-03-13 12:34:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:34:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/5061
Author: @ping-maxwell
Created: 10/3/2025
Status: ✅ Merged
Merged: 10/23/2025
Merged by: @himself65

Base: canary ← Head: fix/org/remove-team-member-breaks-prisma

📝 Commits (5)

  • 8479685 fix(organization): removeTeamMember breaks for prisma
  • ec0bd71 Merge branch 'canary' into fix/org/remove-team-member-breaks-prisma
  • 1911de9 Merge branch 'canary' into fix/org/remove-team-member-breaks-prisma
  • d8a4049 Merge branch 'canary' into fix/org/remove-team-member-breaks-prisma
  • f805b16 Merge branch 'canary' into fix/org/remove-team-member-breaks-prisma

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/organization/adapter.ts (+3 -1)

📄 Description

When using delete in prisma you require at least a unique field. Given that our adapter code is using adpater.delete with 2 FKs and no real unique keys, it will break this operation.

This PR moves it to use deleteMany instead of delete.

closes https://github.com/better-auth/better-auth/issues/5037
linear: https://linear.app/better-auth/issue/ENG-167/fix-authapiremoveteammember-returns-success-but-does-not-delete-team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/5061 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 10/3/2025 **Status:** ✅ Merged **Merged:** 10/23/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/org/remove-team-member-breaks-prisma` --- ### 📝 Commits (5) - [`8479685`](https://github.com/better-auth/better-auth/commit/84796856a51a04d88a14f42822cb2285fe7acf8b) fix(organization): removeTeamMember breaks for prisma - [`ec0bd71`](https://github.com/better-auth/better-auth/commit/ec0bd71ac957c70f5b4b3dcc0b6a7cb30beffd5c) Merge branch 'canary' into fix/org/remove-team-member-breaks-prisma - [`1911de9`](https://github.com/better-auth/better-auth/commit/1911de957e08ba34080ca4266cc25c032b308e0a) Merge branch 'canary' into fix/org/remove-team-member-breaks-prisma - [`d8a4049`](https://github.com/better-auth/better-auth/commit/d8a404917a83eea73fcf961795201f28e35b8143) Merge branch 'canary' into fix/org/remove-team-member-breaks-prisma - [`f805b16`](https://github.com/better-auth/better-auth/commit/f805b16df23487e87baf3c95bf2e8543b4e5c74e) Merge branch 'canary' into fix/org/remove-team-member-breaks-prisma ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/organization/adapter.ts` (+3 -1) </details> ### 📄 Description When using `delete` in prisma you require at least a unique field. Given that our adapter code is using `adpater.delete` with 2 FKs and no real unique keys, it will break this operation. This PR moves it to use `deleteMany` instead of `delete`. closes https://github.com/better-auth/better-auth/issues/5037 linear: https://linear.app/better-auth/issue/ENG-167/fix-authapiremoveteammember-returns-success-but-does-not-delete-team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:34:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5748
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?