github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4756] [MERGED] test: remove async from adapter test #5565

New Issue
Closed
opened 2026-03-13 12:27:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:27:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4756
Author: @himself65
Created: 9/18/2025
Status: ✅ Merged
Merged: 9/18/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/18/async

📝 Commits (1)

  • 80e4d68 test: remove async from adapter test

📊 Changes

13 files changed (+159 additions, -156 deletions)

View changed files

📝 docs/content/docs/guides/create-a-db-adapter.mdx (+2 -2)
📝 packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.mysql.test.ts (+2 -2)
📝 packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.test.ts (+2 -2)
📝 packages/better-auth/src/adapters/kysely-adapter/test/normal/adapter.kysely.test.ts (+6 -5)
📝 packages/better-auth/src/adapters/kysely-adapter/test/normal/node-sqlite-dialect.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/test/number-id/adapter.kysely.number-id.test.ts (+2 -2)
📝 packages/better-auth/src/adapters/memory-adapter/adapter.memory.test.ts (+2 -2)
📝 packages/better-auth/src/adapters/mongodb-adapter/adapter.mongo-db.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/prisma-adapter/test/normal-tests/adapter.prisma.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/adapter.prisma.number-id.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/prisma-adapter/test/test-options.ts (+5 -5)
📝 packages/better-auth/src/adapters/test.ts (+3 -3)
📝 packages/better-auth/src/types/options.ts (+131 -129)

📄 Description

Summary by cubic

Make adapter test runners synchronous by removing async/await usage in tests and docs. Also extract BetterAuthAdvancedOptions as a standalone type and reference it from BetterAuthOptions.

  • Refactors

    • runAdapterTest and runNumberIdAdapterTest are no longer async; adapterTest updated to match.
    • Tests and docs now call the test runners without await.
    • Extracted BetterAuthAdvancedOptions and used it in BetterAuthOptions (types only).

  • Migration

    • Remove await when calling runAdapterTest and runNumberIdAdapterTest.
    • If you use createTestOptions in tests, pass advanced.database options instead of a useNumberId boolean.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4756 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/18/2025 **Status:** ✅ Merged **Merged:** 9/18/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/18/async` --- ### 📝 Commits (1) - [`80e4d68`](https://github.com/better-auth/better-auth/commit/80e4d68fb6f6dd3065d9dedfe8ce0354e01172df) test: remove `async` from adapter test ### 📊 Changes **13 files changed** (+159 additions, -156 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/guides/create-a-db-adapter.mdx` (+2 -2) 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.mysql.test.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.test.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/normal/adapter.kysely.test.ts` (+6 -5) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/normal/node-sqlite-dialect.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/number-id/adapter.kysely.number-id.test.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/memory-adapter/adapter.memory.test.ts` (+2 -2) 📝 `packages/better-auth/src/adapters/mongodb-adapter/adapter.mongo-db.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/normal-tests/adapter.prisma.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/adapter.prisma.number-id.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/test-options.ts` (+5 -5) 📝 `packages/better-auth/src/adapters/test.ts` (+3 -3) 📝 `packages/better-auth/src/types/options.ts` (+131 -129) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Make adapter test runners synchronous by removing async/await usage in tests and docs. Also extract BetterAuthAdvancedOptions as a standalone type and reference it from BetterAuthOptions. - **Refactors** - runAdapterTest and runNumberIdAdapterTest are no longer async; adapterTest updated to match. - Tests and docs now call the test runners without await. - Extracted BetterAuthAdvancedOptions and used it in BetterAuthOptions (types only). - **Migration** - Remove await when calling runAdapterTest and runNumberIdAdapterTest. - If you use createTestOptions in tests, pass advanced.database options instead of a useNumberId boolean. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:27:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5565
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?