github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4750] [MERGED] fix(create-adapter): Disable transaction by default #5560

New Issue
Closed
opened 2026-03-13 12:27:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:27:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4750
Author: @ping-maxwell
Created: 9/18/2025
Status: ✅ Merged
Merged: 9/18/2025
Merged by: @Bekacru

Base: canary ← Head: fix/create-adapter-transaction-disabled-default

📝 Commits (2)

  • 206c4ce fix(create-adapter): Disable transaction by default
  • 7ba2f40 set disabled by default

📊 Changes

6 files changed (+9 additions, -6 deletions)

View changed files

📝 packages/better-auth/src/adapters/adapter-factory/index.ts (+3 -1)
📝 packages/better-auth/src/adapters/adapter-factory/types.ts (+2 -1)
📝 packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts (+1 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts (+1 -1)
📝 packages/better-auth/src/adapters/mongodb-adapter/mongodb-adapter.ts (+1 -1)
📝 packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts (+1 -1)

📄 Description

Summary by cubic

Disable transactions by default in createAdapterFactory so adapters must opt in to transactional behavior. Updates types and docs to reflect transaction: false as the default.

  • Migration
    • If you need transactions, set transaction in AdapterFactoryConfig explicitly.
    • No changes needed if your DB doesn’t support transactions; operations continue sequentially.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4750 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 9/18/2025 **Status:** ✅ Merged **Merged:** 9/18/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/create-adapter-transaction-disabled-default` --- ### 📝 Commits (2) - [`206c4ce`](https://github.com/better-auth/better-auth/commit/206c4ce7bf2e64c5bbe0b0db3d3dc67d6a408de3) fix(create-adapter): Disable transaction by default - [`7ba2f40`](https://github.com/better-auth/better-auth/commit/7ba2f40feff694feac13716773adf52c904d7a96) set disabled by default ### 📊 Changes **6 files changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/adapter-factory/index.ts` (+3 -1) 📝 `packages/better-auth/src/adapters/adapter-factory/types.ts` (+2 -1) 📝 `packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/mongodb-adapter/mongodb-adapter.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts` (+1 -1) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Disable transactions by default in createAdapterFactory so adapters must opt in to transactional behavior. Updates types and docs to reflect transaction: false as the default. - **Migration** - If you need transactions, set transaction in AdapterFactoryConfig explicitly. - No changes needed if your DB doesn’t support transactions; operations continue sequentially. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:27:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5560
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?