github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4723] [MERGED] feat(email-otp): allow returning undefined in generateOTP #5547

New Issue
Closed
opened 2026-03-13 12:26:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:26:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4723
Author: @ping-maxwell
Created: 9/17/2025
Status: ✅ Merged
Merged: 9/17/2025
Merged by: @himself65

Base: canary ← Head: chore/email-otp-generator-return-undefine

📝 Commits (1)

  • 9c3f5d1 chore(email-otp): Allow returning undefined in generateOTP

📊 Changes

1 file changed (+16 additions, -15 deletions)

View changed files

📝 packages/better-auth/src/plugins/email-otp/index.ts (+16 -15)

📄 Description

Right now you're forced to return an OTP value in the generateOTP function as part of the email-otp plugin. In some cases you may just want to return an OTP under a specific case, and just have nothing else returned to default to the default OTP generator.

Summary by cubic

Let generateOTP in the email-otp plugin return undefined and fall back to the default numeric generator. This lets you only override OTPs for specific cases.

  • New Features
    • generateOTP can now return string | undefined.
    • Added a defaultOTPGenerator and a safe fallback when generateOTP returns undefined.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4723 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 9/17/2025 **Status:** ✅ Merged **Merged:** 9/17/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `chore/email-otp-generator-return-undefine` --- ### 📝 Commits (1) - [`9c3f5d1`](https://github.com/better-auth/better-auth/commit/9c3f5d1c4e8534d1f3407d384449cb6463545d0a) chore(email-otp): Allow returning undefined in `generateOTP` ### 📊 Changes **1 file changed** (+16 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/email-otp/index.ts` (+16 -15) </details> ### 📄 Description Right now you're forced to return an OTP value in the `generateOTP` function as part of the email-otp plugin. In some cases you may just want to return an OTP under a specific case, and just have nothing else returned to default to the default OTP generator. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Let generateOTP in the email-otp plugin return undefined and fall back to the default numeric generator. This lets you only override OTPs for specific cases. - **New Features** - generateOTP can now return string | undefined. - Added a defaultOTPGenerator and a safe fallback when generateOTP returns undefined. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:26:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5547
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?