github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4666] [MERGED] test: use execSync #5516

New Issue
Closed
opened 2026-03-13 12:25:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:25:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4666
Author: @himself65
Created: 9/15/2025
Status: ✅ Merged
Merged: 9/15/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/14/schema

📝 Commits (1)

📊 Changes

3 files changed (+6 additions, -32 deletions)

View changed files

📝 packages/better-auth/src/adapters/prisma-adapter/test/normal-tests/adapter.prisma.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/adapter.prisma.number-id.test.ts (+1 -1)
📝 packages/better-auth/src/adapters/prisma-adapter/test/push-schema.ts (+4 -30)

📄 Description

Summary by cubic

Switch tests to use execSync for Prisma schema pushes. Streams output and avoids async race conditions during setup.

  • Refactors
    • Replaced custom async exec wrapper with execSync({ stdio: "inherit" }).
    • Made pushPrismaSchema synchronous and removed await in both test suites.
    • Improves reliability and fails fast with clear console output.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4666 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/15/2025 **Status:** ✅ Merged **Merged:** 9/15/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/14/schema` --- ### 📝 Commits (1) - [`f31107c`](https://github.com/better-auth/better-auth/commit/f31107c0643ac0b383cf59e6634674ce7762c411) test: use `execSync` ### 📊 Changes **3 files changed** (+6 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/prisma-adapter/test/normal-tests/adapter.prisma.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/adapter.prisma.number-id.test.ts` (+1 -1) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/push-schema.ts` (+4 -30) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Switch tests to use execSync for Prisma schema pushes. Streams output and avoids async race conditions during setup. - **Refactors** - Replaced custom async exec wrapper with execSync({ stdio: "inherit" }). - Made pushPrismaSchema synchronous and removed await in both test suites. - Improves reliability and fails fast with clear console output. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:25:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?