github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4646] [CLOSED] test: fix flaky test #5503

New Issue
Closed
opened 2026-03-13 12:25:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:25:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4646
Author: @himself65
Created: 9/14/2025
Status: ❌ Closed

Base: canary ← Head: himself65/2025/09/14/falky

📝 Commits (3)

  • 2576b77 test: fix flaky test
  • 7e4233e chore: lint fix
  • db42d2e Merge branch 'canary' into himself65/2025/09/14/falky

📊 Changes

1 file changed (+60 additions, -12 deletions)

View changed files

📝 packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts (+60 -12)

📄 Description

Summary by cubic

Fixes flaky tests by normalizing ID types in the Prisma adapter when useNumberId is enabled. Queries and writes now consistently use numeric IDs to avoid type mismatches.

  • Bug Fixes
    • Convert id, userId, and any field ending with Id (including arrays) to numbers in where clauses.
    • Coerce foreign key IDs in create, update, and updateMany payloads via a new convertDataValues helper.
    • Apply conversions across single, AND, and OR filter paths.
    • No changes when useNumberId is disabled.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4646 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/14/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `himself65/2025/09/14/falky` --- ### 📝 Commits (3) - [`2576b77`](https://github.com/better-auth/better-auth/commit/2576b778b547a8e9a32176f29f7794e9cb66107f) test: fix flaky test - [`7e4233e`](https://github.com/better-auth/better-auth/commit/7e4233e9266015c589a15b7ea25fb66b97a41fa8) chore: lint fix - [`db42d2e`](https://github.com/better-auth/better-auth/commit/db42d2e008bdde9d450accd11b040ad47b7f0c44) Merge branch 'canary' into himself65/2025/09/14/falky ### 📊 Changes **1 file changed** (+60 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts` (+60 -12) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fixes flaky tests by normalizing ID types in the Prisma adapter when useNumberId is enabled. Queries and writes now consistently use numeric IDs to avoid type mismatches. - **Bug Fixes** - Convert id, userId, and any field ending with Id (including arrays) to numbers in where clauses. - Coerce foreign key IDs in create, update, and updateMany payloads via a new convertDataValues helper. - Apply conversions across single, AND, and OR filter paths. - No changes when useNumberId is disabled. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:25:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5503
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?