github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-31 11:26:42 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4606] [MERGED] fix: remove use of global.crypto #5480

New Issue
Closed
opened 2026-03-13 12:24:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:24:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4606
Author: @himself65
Created: 9/12/2025
Status: ✅ Merged
Merged: 9/12/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/12/crypto

📝 Commits (1)

  • 3f87595 fix: remove use of global.crypto

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/plugins/jwt/utils.ts (+1 -1)

📄 Description

Related: https://github.com/better-auth/better-auth/issues/4471

This has been brought in a very old version, since 0.8. So I don't think this will fix the issue, but let's not use crypto

Summary by cubic

Remove direct use of global.crypto in JWT key derivation to prevent runtime errors in environments where crypto isn’t on the global object (e.g., some edge/bundler targets). We now call subtle.importKey directly so PBKDF2 works across runtimes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4606 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/12/2025 **Status:** ✅ Merged **Merged:** 9/12/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/12/crypto` --- ### 📝 Commits (1) - [`3f87595`](https://github.com/better-auth/better-auth/commit/3f87595f9165a465a6a97c36e84e065ff1de6f59) fix: remove use of `global.crypto` ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/jwt/utils.ts` (+1 -1) </details> ### 📄 Description Related: https://github.com/better-auth/better-auth/issues/4471 This has been brought in a very old version, since 0.8. So I don't think this will fix the issue, but let's not use `crypto` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Remove direct use of global.crypto in JWT key derivation to prevent runtime errors in environments where crypto isn’t on the global object (e.g., some edge/bundler targets). We now call subtle.importKey directly so PBKDF2 works across runtimes. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:24:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5480
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?