github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

supports outside auth like idToken but for e.g. access_token and etc.. #548

New Issue
Closed
opened 2026-03-13 07:52:17 -05:00 by GiteaMirror · 7 comments
GiteaMirror commented 2026-03-13 07:52:17 -05:00
Owner
Copy Link

Originally created by @reslear on GitHub (Jan 11, 2025).

Is this suited for github?

  • Yes, this is suited for github

Is your feature request related to a problem? Please describe.

  1. pass full ctx and allow use headers for example fix https://github.com/better-auth/better-auth/issues/1214

  2. pass access_token to verifyIdTokenfor example https://github.com/better-auth/better-auth/pull/1078

Describe the solution you'd like

cc94e6a7c0/packages/better-auth/src/api/routes/sign-in.ts (L187-L188)

replace cb verifyIdToken to functions verify to and pass all token arguments c.body.idToken

Describe alternatives you've considered

  1. just add accessToken as 3-n param or all c.body.idToken:
const valid = await provider.verifyIdToken(token, nonce, accessToken);

Additional context

No response

Originally created by @reslear on GitHub (Jan 11, 2025). ### Is this suited for github? - [X] Yes, this is suited for github ### Is your feature request related to a problem? Please describe. 1. pass full `ctx` and allow use headers for example fix https://github.com/better-auth/better-auth/issues/1214 2. pass `access_token` to `verifyIdToken`for example https://github.com/better-auth/better-auth/pull/1078 ### Describe the solution you'd like https://github.com/better-auth/better-auth/blob/cc94e6a7c07c5742938a15e6e340d3dde3de17b3/packages/better-auth/src/api/routes/sign-in.ts#L187-L188 replace cb `verifyIdToken` to functions `verify` to and pass all token arguments `c.body.idToken` ### Describe alternatives you've considered 3. just add `accessToken` as 3-n param or all `c.body.idToken`: ```ts const valid = await provider.verifyIdToken(token, nonce, accessToken); ``` ### Additional context _No response_
GiteaMirror commented 2026-03-13 07:52:18 -05:00
Author
Owner
Copy Link

@dosubot[bot] commented on GitHub (Jun 12, 2025):

Hi, @reslear. I'm Dosu, and I'm helping the better-auth team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • Proposal to enhance Better Auth library to support external authentication methods.
  • Suggested changes include using access tokens, passing full context and headers, and modifying verifyIdToken.
  • No comments or developments have been made on this issue yet.

Next Steps:

  • Please confirm if this issue is still relevant to the latest version of the better-auth repository by commenting here.
  • If there is no response, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Jun 12, 2025): Hi, @reslear. I'm [Dosu](https://dosu.dev), and I'm helping the better-auth team manage their backlog. I'm marking this issue as stale. **Issue Summary:** - Proposal to enhance Better Auth library to support external authentication methods. - Suggested changes include using access tokens, passing full context and headers, and modifying `verifyIdToken`. - No comments or developments have been made on this issue yet. **Next Steps:** - Please confirm if this issue is still relevant to the latest version of the better-auth repository by commenting here. - If there is no response, the issue will be automatically closed in 7 days. Thank you for your understanding and contribution!
GiteaMirror commented 2026-03-13 07:52:19 -05:00
Author
Owner
Copy Link

@reslear commented on GitHub (Jun 12, 2025):

not outdated, everything would still be cool to pass ctx like
https://github.com/better-auth/better-auth/commit/57e2b8bd

@reslear commented on GitHub (Jun 12, 2025): not outdated, everything would still be cool to pass ctx like https://github.com/better-auth/better-auth/commit/57e2b8bd
GiteaMirror commented 2026-03-13 07:52:19 -05:00
Author
Owner
Copy Link

@dosubot[bot] commented on GitHub (Sep 11, 2025):

Hi, @reslear. I'm Dosu, and I'm helping the better-auth team manage their backlog and am marking this issue as stale.

Issue Summary:

  • You requested enhancing Better Auth to support external authentication tokens beyond just idToken.
  • The proposal includes passing full context and headers to verification functions.
  • You suggested modifying verifyIdToken to a more flexible verify function.
  • You confirmed the request remains valid after the issue was marked stale previously.
  • No further developments or updates have occurred since your last confirmation.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of better-auth by commenting here.
  • If I don’t hear back within 7 days, I will automatically close this issue.

Thanks for your understanding and contribution!

@dosubot[bot] commented on GitHub (Sep 11, 2025): Hi, @reslear. I'm [Dosu](https://dosu.dev), and I'm helping the better-auth team manage their backlog and am marking this issue as stale. **Issue Summary:** - You requested enhancing Better Auth to support external authentication tokens beyond just idToken. - The proposal includes passing full context and headers to verification functions. - You suggested modifying verifyIdToken to a more flexible verify function. - You confirmed the request remains valid after the issue was marked stale previously. - No further developments or updates have occurred since your last confirmation. **Next Steps:** - Please let me know if this issue is still relevant to the latest version of better-auth by commenting here. - If I don’t hear back within 7 days, I will automatically close this issue. Thanks for your understanding and contribution!
GiteaMirror commented 2026-03-13 07:52:20 -05:00
Author
Owner
Copy Link

@reslear commented on GitHub (Sep 11, 2025):

not outdated

@reslear commented on GitHub (Sep 11, 2025): not outdated
GiteaMirror commented 2026-03-13 07:52:20 -05:00
Author
Owner
Copy Link

@reslear commented on GitHub (Dec 9, 2025):

@Paola3stefania ?

@reslear commented on GitHub (Dec 9, 2025): @Paola3stefania ?
GiteaMirror commented 2026-03-13 07:52:20 -05:00
Author
Owner
Copy Link

@reslear commented on GitHub (Jan 3, 2026):

hi @Paola3stefania Could you explain the closure of the issue?

@reslear commented on GitHub (Jan 3, 2026): hi @Paola3stefania Could you explain the closure of the issue?
GiteaMirror commented 2026-03-13 07:52:21 -05:00
Author
Owner
Copy Link

@reslear commented on GitHub (Feb 3, 2026):

hi @Paola3stefania Could you explain the closure of the issue?

@reslear commented on GitHub (Feb 3, 2026): hi @Paola3stefania Could you explain the closure of the issue?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#548
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?