github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4596] [MERGED] fix: set clientId in ProviderOptions to unknown by default #5470

New Issue
Closed
opened 2026-03-13 12:24:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:24:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4596
Author: @himself65
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/11/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/09/11/provider-options

📝 Commits (3)

  • 5efb3f0 fix: set clientId in ProviderOptions to unknown by default
  • 86a3843 fix: array support
  • 4b8a458 fix: type

📊 Changes

35 files changed (+96 additions, -22 deletions)

View changed files

📝 packages/better-auth/src/oauth2/client-credentials-token.ts (+10 -1)
📝 packages/better-auth/src/oauth2/create-authorization-url.ts (+8 -1)
📝 packages/better-auth/src/oauth2/refresh-access-token.ts (+8 -1)
📝 packages/better-auth/src/oauth2/types.ts (+4 -2)
📝 packages/better-auth/src/oauth2/validate-authorization-code.ts (+8 -1)
📝 packages/better-auth/src/social-providers/apple.ts (+1 -0)
📝 packages/better-auth/src/social-providers/atlassian.ts (+3 -1)
📝 packages/better-auth/src/social-providers/cognito.ts (+1 -0)
📝 packages/better-auth/src/social-providers/discord.ts (+1 -0)
📝 packages/better-auth/src/social-providers/dropbox.ts (+1 -0)
📝 packages/better-auth/src/social-providers/facebook.ts (+1 -0)
📝 packages/better-auth/src/social-providers/figma.ts (+3 -1)
📝 packages/better-auth/src/social-providers/github.ts (+3 -1)
📝 packages/better-auth/src/social-providers/gitlab.ts (+1 -0)
📝 packages/better-auth/src/social-providers/google.ts (+1 -0)
📝 packages/better-auth/src/social-providers/huggingface.ts (+3 -1)
📝 packages/better-auth/src/social-providers/kakao.ts (+3 -1)
📝 packages/better-auth/src/social-providers/kick.ts (+3 -1)
📝 packages/better-auth/src/social-providers/line.ts (+3 -1)
📝 packages/better-auth/src/social-providers/linear.ts (+3 -1)

...and 15 more files

📄 Description

Fixes: https://github.com/better-auth/better-auth/pull/4583/files#r2342548852

Summary by cubic

Make clientId in ProviderOptions optional and typed as unknown. Require a string clientId in each social provider where applicable (TikTok remains no-clientId), improving type safety and aligning with provider specs.

  • Refactors

    • ProviderOptions.clientId is now optional unknown with updated docs.
    • All providers now explicitly require clientId: string, except TikTok (clientId?: never).
    • Clarifies provider-specific typing without forcing a global string type.

  • Migration

    • Ensure you pass clientId: string to all providers except TikTok.
    • For TikTok, remove any clientId usage.
    • Custom providers: set your desired clientId type or keep it as unknown if the provider varies.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4596 **Author:** [@himself65](https://github.com/himself65) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/11/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/09/11/provider-options` --- ### 📝 Commits (3) - [`5efb3f0`](https://github.com/better-auth/better-auth/commit/5efb3f0bb349a613b7d1663dafc496a2ffa0fcb6) fix: set clientId in ProviderOptions to `unknown` by default - [`86a3843`](https://github.com/better-auth/better-auth/commit/86a3843b7e6613384043caa02459fbcf571950fc) fix: array support - [`4b8a458`](https://github.com/better-auth/better-auth/commit/4b8a458db0f40c7e116637f0ae77702f1ec5290c) fix: type ### 📊 Changes **35 files changed** (+96 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/oauth2/client-credentials-token.ts` (+10 -1) 📝 `packages/better-auth/src/oauth2/create-authorization-url.ts` (+8 -1) 📝 `packages/better-auth/src/oauth2/refresh-access-token.ts` (+8 -1) 📝 `packages/better-auth/src/oauth2/types.ts` (+4 -2) 📝 `packages/better-auth/src/oauth2/validate-authorization-code.ts` (+8 -1) 📝 `packages/better-auth/src/social-providers/apple.ts` (+1 -0) 📝 `packages/better-auth/src/social-providers/atlassian.ts` (+3 -1) 📝 `packages/better-auth/src/social-providers/cognito.ts` (+1 -0) 📝 `packages/better-auth/src/social-providers/discord.ts` (+1 -0) 📝 `packages/better-auth/src/social-providers/dropbox.ts` (+1 -0) 📝 `packages/better-auth/src/social-providers/facebook.ts` (+1 -0) 📝 `packages/better-auth/src/social-providers/figma.ts` (+3 -1) 📝 `packages/better-auth/src/social-providers/github.ts` (+3 -1) 📝 `packages/better-auth/src/social-providers/gitlab.ts` (+1 -0) 📝 `packages/better-auth/src/social-providers/google.ts` (+1 -0) 📝 `packages/better-auth/src/social-providers/huggingface.ts` (+3 -1) 📝 `packages/better-auth/src/social-providers/kakao.ts` (+3 -1) 📝 `packages/better-auth/src/social-providers/kick.ts` (+3 -1) 📝 `packages/better-auth/src/social-providers/line.ts` (+3 -1) 📝 `packages/better-auth/src/social-providers/linear.ts` (+3 -1) _...and 15 more files_ </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/pull/4583/files#r2342548852 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Make clientId in ProviderOptions optional and typed as unknown. Require a string clientId in each social provider where applicable (TikTok remains no-clientId), improving type safety and aligning with provider specs. - **Refactors** - ProviderOptions.clientId is now optional unknown with updated docs. - All providers now explicitly require clientId: string, except TikTok (clientId?: never). - Clarifies provider-specific typing without forcing a global string type. - **Migration** - Ensure you pass clientId: string to all providers except TikTok. - For TikTok, remove any clientId usage. - Custom providers: set your desired clientId type or keep it as unknown if the provider varies. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:24:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5470
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?