github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-07-12 11:05:58 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4511] [MERGED] fix(tiktok): remove client_secrect from authorizationUrl #5418

New Issue
Closed
opened 2026-03-13 12:22:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:22:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4511
Author: @arslan2012
Created: 9/8/2025
Status: ✅ Merged
Merged: 9/8/2025
Merged by: @Kinfe123

Base: canary ← Head: patch-2

📝 Commits (1)

  • d48dc3b Update TikTok authorization URL parameters

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 packages/better-auth/src/social-providers/tiktok.ts (+1 -3)

📄 Description

This PR is based on issue https://github.com/better-auth/better-auth/issues/4509

client secret is not only not needed in authorization url. it is dangerous to send it to client

Summary by cubic

Removed client_secret from the TikTok provider authorization URL. This avoids exposing the secret to clients and aligns with TikTok’s OAuth spec (only client_key is required).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4511 **Author:** [@arslan2012](https://github.com/arslan2012) **Created:** 9/8/2025 **Status:** ✅ Merged **Merged:** 9/8/2025 **Merged by:** [@Kinfe123](https://github.com/Kinfe123) **Base:** `canary` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`d48dc3b`](https://github.com/better-auth/better-auth/commit/d48dc3bc6bf65410f8c3a46fbe2ce9610699f5ae) Update TikTok authorization URL parameters ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/social-providers/tiktok.ts` (+1 -3) </details> ### 📄 Description This PR is based on issue https://github.com/better-auth/better-auth/issues/4509 client secret is not only not needed in authorization url. it is dangerous to send it to client <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removed client_secret from the TikTok provider authorization URL. This avoids exposing the secret to clients and aligns with TikTok’s OAuth spec (only client_key is required). <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:22:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5418
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?