github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4501] [MERGED] fix: revert set default iat for /token endpoint #5412

New Issue
Closed
opened 2026-03-13 12:22:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:22:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4501
Author: @dvanmali
Created: 9/7/2025
Status: ✅ Merged
Merged: 9/7/2025
Merged by: @Bekacru

Base: canary ← Head: jwt-iat

📝 Commits (1)

  • 2634c4a fix: revert - provide iat for /token endpoint

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/plugins/jwt/sign.ts (+1 -0)

📄 Description

Revert, return missing iat claim from token endpoint.

iat itself is an optional claim, hense SHALL NOT be put in the signJWT function.

Addresses @erquhart comment on PR #4074

Summary by cubic

Restore the iat claim on JWTs returned by the /token endpoint by adding iat (UNIX seconds) to the payload in getJwtToken. Scope iat to this endpoint only, keeping the claim optional elsewhere and avoiding a default in signJWT.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4501 **Author:** [@dvanmali](https://github.com/dvanmali) **Created:** 9/7/2025 **Status:** ✅ Merged **Merged:** 9/7/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `jwt-iat` --- ### 📝 Commits (1) - [`2634c4a`](https://github.com/better-auth/better-auth/commit/2634c4af9d89cf9b7c7692ad3fe29c18d658bcd8) fix: revert - provide iat for /token endpoint ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/jwt/sign.ts` (+1 -0) </details> ### 📄 Description Revert, return missing `iat` claim from token endpoint. `iat` itself is an optional claim, hense **SHALL NOT** be put in the `signJWT` function. Addresses @erquhart [comment](https://github.com/better-auth/better-auth/pull/4074#issuecomment-3263875308) on PR #4074 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Restore the iat claim on JWTs returned by the /token endpoint by adding iat (UNIX seconds) to the payload in getJwtToken. Scope iat to this endpoint only, keeping the claim optional elsewhere and avoiding a default in signJWT. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:22:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5412
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?