github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4361] [MERGED] fix: prevent undefined from passed to adapter in username plugin #5330

New Issue
Closed
opened 2026-03-13 12:19:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:19:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4361
Author: @Kinfe123
Created: 9/2/2025
Status: ✅ Merged
Merged: 9/2/2025
Merged by: @Kinfe123

Base: canary ← Head: fix/prisma-strict-undefined-checks-username-plugin

📝 Commits (1)

  • 00c74da fix: prevent undefined values from reaching Prisma adapter in username plugin

📊 Changes

2 files changed (+9 additions, -3 deletions)

View changed files

📝 packages/better-auth/src/adapters/create-adapter/index.ts (+3 -1)
📝 packages/better-auth/src/plugins/username/index.ts (+6 -2)

📄 Description

closes #4341
before
Screenshot 2025-09-02 at 2 13 29 PM
after
Screenshot 2025-09-02 at 2 13 36 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4361 **Author:** [@Kinfe123](https://github.com/Kinfe123) **Created:** 9/2/2025 **Status:** ✅ Merged **Merged:** 9/2/2025 **Merged by:** [@Kinfe123](https://github.com/Kinfe123) **Base:** `canary` ← **Head:** `fix/prisma-strict-undefined-checks-username-plugin` --- ### 📝 Commits (1) - [`00c74da`](https://github.com/better-auth/better-auth/commit/00c74daeea95f9cc757be09e36610a60d9f90e7d) fix: prevent undefined values from reaching Prisma adapter in username plugin ### 📊 Changes **2 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/create-adapter/index.ts` (+3 -1) 📝 `packages/better-auth/src/plugins/username/index.ts` (+6 -2) </details> ### 📄 Description closes #4341 before <img width="272" height="167" alt="Screenshot 2025-09-02 at 2 13 29 PM" src="https://github.com/user-attachments/assets/b6cb336e-00c7-477a-a681-a76da8e9fe19" /> after <img width="369" height="20" alt="Screenshot 2025-09-02 at 2 13 36 PM" src="https://github.com/user-attachments/assets/5b19e66f-4c43-4e1d-8a85-a91af0633d37" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:19:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5330
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?