github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4306] [MERGED] chore: inline ms code during build stage #5304

New Issue
Closed
opened 2026-03-13 12:17:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:17:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4306
Author: @himself65
Created: 8/29/2025
Status: ✅ Merged
Merged: 8/29/2025
Merged by: @himself65

Base: canary ← Head: himself65/2025/08/29/inline-ms

📝 Commits (1)

  • af08c72 chore: inline ms code during build stage

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 packages/better-auth/package.json (+1 -1)
📝 pnpm-lock.yaml (+3 -3)

📄 Description

from @Bekacru

https://github.com/better-auth/better-auth/pull/4299/files - we should generally avoid introducing new deps specially for utility ones

Summary by cubic

Inlines ms during build to avoid shipping it as a runtime dependency. Moves ms to devDependencies and updates the lockfile, reducing runtime bloat and aligning with the “avoid new utility deps” guideline.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4306 **Author:** [@himself65](https://github.com/himself65) **Created:** 8/29/2025 **Status:** ✅ Merged **Merged:** 8/29/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `himself65/2025/08/29/inline-ms` --- ### 📝 Commits (1) - [`af08c72`](https://github.com/better-auth/better-auth/commit/af08c7288ef809830d3b42cbc40e37edb9635fa4) chore: inline `ms` code during build stage ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/package.json` (+1 -1) 📝 `pnpm-lock.yaml` (+3 -3) </details> ### 📄 Description from @Bekacru > https://github.com/better-auth/better-auth/pull/4299/files - we should generally avoid introducing new deps specially for utility ones <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Inlines ms during build to avoid shipping it as a runtime dependency. Moves ms to devDependencies and updates the lockfile, reducing runtime bloat and aligning with the “avoid new utility deps” guideline. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:17:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5304
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?