github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4093] [CLOSED] fix(api-key): avoid blocking verification with delete and update operations #5184

New Issue
Closed
opened 2026-03-13 12:13:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:13:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4093
Author: @Bekacru
Created: 8/19/2025
Status: ❌ Closed

Base: canary ← Head: fix/api-key-blocking

📝 Commits (2)

  • dbb58cb avoid blocking delete and update for api keys
  • e04a53c Merge branch 'canary' into fix/api-key-blocking

📊 Changes

1 file changed (+8 additions, -10 deletions)

View changed files

📝 packages/better-auth/src/plugins/api-key/routes/verify-api-key.ts (+8 -10)

📄 Description

Summary by cubic

Make API key verification non-blocking. Updates and expired-key cleanup now run in the background to avoid slow adapters blocking requests and to reduce latency.

  • Bug Fixes
    • Stop awaiting adapter.update in validateApiKey and remove the hard failure when it returns null; return the merged key state instead.
    • Call deleteAllExpiredApiKeys without await so cleanup doesn’t block verification.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4093 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 8/19/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/api-key-blocking` --- ### 📝 Commits (2) - [`dbb58cb`](https://github.com/better-auth/better-auth/commit/dbb58cbb786599c32f775bc719a2510839060b28) avoid blocking delete and update for api keys - [`e04a53c`](https://github.com/better-auth/better-auth/commit/e04a53cdeb1f6131fc15ac97471a7184e7469eaf) Merge branch 'canary' into fix/api-key-blocking ### 📊 Changes **1 file changed** (+8 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/api-key/routes/verify-api-key.ts` (+8 -10) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Make API key verification non-blocking. Updates and expired-key cleanup now run in the background to avoid slow adapters blocking requests and to reduce latency. - **Bug Fixes** - Stop awaiting adapter.update in validateApiKey and remove the hard failure when it returns null; return the merged key state instead. - Call deleteAllExpiredApiKeys without await so cleanup doesn’t block verification. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:13:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5184
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?