github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #4019] fix: social provider types should require fields based on the provider requirement #5139

New Issue
Open
opened 2026-03-13 12:11:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:11:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/4019
Author: @Bekacru
Created: 8/15/2025
Status: 🔄 Open

Base: canary ← Head: fix/oauth-types

📝 Commits (4)

  • fac8c2c fix: social provider types should require fields based on the provider requirement
  • 6ef6eea chore: lint
  • 187a688 chore: fix typpo
  • 99b1155 Merge branch 'canary' into fix/oauth-types

📊 Changes

23 files changed (+177 additions, -17 deletions)

View changed files

📝 packages/better-auth/src/oauth2/types.ts (+1 -1)
📝 packages/better-auth/src/social-providers/discord.ts (+2 -0)
📝 packages/better-auth/src/social-providers/dropbox.ts (+8 -1)
📝 packages/better-auth/src/social-providers/facebook.ts (+8 -2)
📝 packages/better-auth/src/social-providers/github.ts (+10 -1)
📝 packages/better-auth/src/social-providers/gitlab.ts (+8 -0)
📝 packages/better-auth/src/social-providers/google.ts (+8 -0)
📝 packages/better-auth/src/social-providers/huggingface.ts (+10 -1)
📝 packages/better-auth/src/social-providers/kick.ts (+10 -1)
📝 packages/better-auth/src/social-providers/linear.ts (+10 -1)
📝 packages/better-auth/src/social-providers/linkedin.ts (+10 -1)
📝 packages/better-auth/src/social-providers/microsoft-entra-id.ts (+8 -0)
📝 packages/better-auth/src/social-providers/notion.ts (+10 -1)
📝 packages/better-auth/src/social-providers/reddit.ts (+8 -0)
📝 packages/better-auth/src/social-providers/roblox.ts (+11 -0)
📝 packages/better-auth/src/social-providers/slack.ts (+10 -1)
📝 packages/better-auth/src/social-providers/social.test.ts (+1 -1)
📝 packages/better-auth/src/social-providers/spotify.ts (+10 -1)
📝 packages/better-auth/src/social-providers/tiktok.ts (+0 -2)
📝 packages/better-auth/src/social-providers/twitch.ts (+8 -0)

...and 3 more files

📄 Description

Summary by cubic

Updated OAuth social provider types to require clientId and clientSecret fields only for providers that actually need them. This improves type safety and validation when setting up provider integrations.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/4019 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 8/15/2025 **Status:** 🔄 Open **Base:** `canary` ← **Head:** `fix/oauth-types` --- ### 📝 Commits (4) - [`fac8c2c`](https://github.com/better-auth/better-auth/commit/fac8c2cb8155d3a3e8fc9f70acfda6a73d8149f4) fix: social provider types should require fields based on the provider requirement - [`6ef6eea`](https://github.com/better-auth/better-auth/commit/6ef6eea6200db291b40703b2eabcd78ddd32a10d) chore: lint - [`187a688`](https://github.com/better-auth/better-auth/commit/187a688fb61c0d448b8842846275fce678ba234f) chore: fix typpo - [`99b1155`](https://github.com/better-auth/better-auth/commit/99b11558da335de1a10e16ebb89514ffae40f5f4) Merge branch 'canary' into fix/oauth-types ### 📊 Changes **23 files changed** (+177 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/oauth2/types.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/discord.ts` (+2 -0) 📝 `packages/better-auth/src/social-providers/dropbox.ts` (+8 -1) 📝 `packages/better-auth/src/social-providers/facebook.ts` (+8 -2) 📝 `packages/better-auth/src/social-providers/github.ts` (+10 -1) 📝 `packages/better-auth/src/social-providers/gitlab.ts` (+8 -0) 📝 `packages/better-auth/src/social-providers/google.ts` (+8 -0) 📝 `packages/better-auth/src/social-providers/huggingface.ts` (+10 -1) 📝 `packages/better-auth/src/social-providers/kick.ts` (+10 -1) 📝 `packages/better-auth/src/social-providers/linear.ts` (+10 -1) 📝 `packages/better-auth/src/social-providers/linkedin.ts` (+10 -1) 📝 `packages/better-auth/src/social-providers/microsoft-entra-id.ts` (+8 -0) 📝 `packages/better-auth/src/social-providers/notion.ts` (+10 -1) 📝 `packages/better-auth/src/social-providers/reddit.ts` (+8 -0) 📝 `packages/better-auth/src/social-providers/roblox.ts` (+11 -0) 📝 `packages/better-auth/src/social-providers/slack.ts` (+10 -1) 📝 `packages/better-auth/src/social-providers/social.test.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/spotify.ts` (+10 -1) 📝 `packages/better-auth/src/social-providers/tiktok.ts` (+0 -2) 📝 `packages/better-auth/src/social-providers/twitch.ts` (+8 -0) _...and 3 more files_ </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Updated OAuth social provider types to require clientId and clientSecret fields only for providers that actually need them. This improves type safety and validation when setting up provider integrations. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:11:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5139
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?