github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3975] [CLOSED] refactor(cli): remove unused integer import from drizzle schema gener… #5117

New Issue
Closed
opened 2026-03-13 12:11:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:11:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3975
Author: @Boby900
Created: 8/13/2025
Status: ❌ Closed

Base: canary ← Head: feat/remove-unused-integer-import

📝 Commits (1)

  • 766d9e8 refactor(cli): remove unused integer import from drizzle schema generation

📊 Changes

2 files changed (+68 additions, -28 deletions)

View changed files

📝 packages/cli/src/generators/drizzle.ts (+29 -28)
📝 packages/cli/test/generate.test.ts (+39 -0)

📄 Description

…ation

  • Add check for integer fields before including import
  • Only import integer when useNumberId is true or number fields exist
  • Add tests to verify import behavior

Fixes #3971

Summary by cubic

Removed unused integer import from drizzle schema generation. Now, integer is only imported if useNumberId is true or number fields exist.

  • Bug Fixes
  • Added checks to prevent unnecessary integer imports.
  • Updated tests to verify correct import behavior.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3975 **Author:** [@Boby900](https://github.com/Boby900) **Created:** 8/13/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `feat/remove-unused-integer-import` --- ### 📝 Commits (1) - [`766d9e8`](https://github.com/better-auth/better-auth/commit/766d9e8cf946bb1b3189b0000201fcd6767bd3b3) refactor(cli): remove unused integer import from drizzle schema generation ### 📊 Changes **2 files changed** (+68 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `packages/cli/src/generators/drizzle.ts` (+29 -28) 📝 `packages/cli/test/generate.test.ts` (+39 -0) </details> ### 📄 Description …ation - Add check for integer fields before including import - Only import integer when useNumberId is true or number fields exist - Add tests to verify import behavior Fixes #3971 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removed unused integer import from drizzle schema generation. Now, integer is only imported if useNumberId is true or number fields exist. - **Bug Fixes** - Added checks to prevent unnecessary integer imports. - Updated tests to verify correct import behavior. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:11:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5117
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?