github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3948] [CLOSED] feat: async baseURL support #5103

New Issue
Closed
opened 2026-03-13 12:10:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:10:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3948
Author: @Kinfe123
Created: 8/12/2025
Status: ❌ Closed

Base: main ← Head: fix/async-baseurl-support

📝 Commits (6)

📊 Changes

16 files changed (+132 additions, -38 deletions)

View changed files

📝 packages/better-auth/src/auth.ts (+21 -4)
📝 packages/better-auth/src/cookies/index.ts (+4 -4)
📝 packages/better-auth/src/init.test.ts (+46 -0)
📝 packages/better-auth/src/init.ts (+14 -3)
📝 packages/better-auth/src/integrations/svelte-kit.ts (+5 -3)
📝 packages/better-auth/src/oauth2/state.ts (+1 -1)
📝 packages/better-auth/src/plugins/jwt/sign.ts (+7 -4)
📝 packages/better-auth/src/plugins/magic-link/index.ts (+2 -2)
📝 packages/better-auth/src/plugins/mcp/index.ts (+7 -2)
📝 packages/better-auth/src/plugins/oauth-proxy/index.ts (+2 -2)
📝 packages/better-auth/src/plugins/oidc-provider/index.ts (+1 -1)
📝 packages/better-auth/src/plugins/passkey/index.ts (+4 -4)
📝 packages/better-auth/src/telemetry/index.ts (+2 -3)
📝 packages/better-auth/src/test-utils/index.ts (+3 -1)
📝 packages/better-auth/src/test-utils/test-instance.ts (+3 -1)
📝 packages/better-auth/src/types/options.ts (+10 -3)

📄 Description

Summary by cubic

Added support for async and per-request baseURL resolution in Better Auth, allowing dynamic baseURL values using a function.

  • New Features
    • baseURL can now be a function that receives the request and context, and returns a string or Promise.
    • All internal usage and plugins updated to handle dynamic baseURL values.
    • New tests added for async baseURL scenarios.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3948 **Author:** [@Kinfe123](https://github.com/Kinfe123) **Created:** 8/12/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/async-baseurl-support` --- ### 📝 Commits (6) - [`f04b671`](https://github.com/better-auth/better-auth/commit/f04b67143ace44d85a4675b7f9121c9fa77e3865) feat: async base url support - [`f559fa3`](https://github.com/better-auth/better-auth/commit/f559fa3700cf0b610d6bb41d148c5cdae33149e2) lint - [`69e15d2`](https://github.com/better-auth/better-auth/commit/69e15d230c0799eeac316078c2df53976eeda5d0) Merge branch 'main' into fix/async-baseurl-support - [`69b0332`](https://github.com/better-auth/better-auth/commit/69b033293af193e8483d4b043b31687c3c4ac099) lint - [`52e594f`](https://github.com/better-auth/better-auth/commit/52e594f5765c3a6bbd5a0a504f2cb716549f6139) temporal baseURL fix - [`d08c1d7`](https://github.com/better-auth/better-auth/commit/d08c1d7bff13944ce1725d84e1682ebba5fbaf3b) type ### 📊 Changes **16 files changed** (+132 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/auth.ts` (+21 -4) 📝 `packages/better-auth/src/cookies/index.ts` (+4 -4) 📝 `packages/better-auth/src/init.test.ts` (+46 -0) 📝 `packages/better-auth/src/init.ts` (+14 -3) 📝 `packages/better-auth/src/integrations/svelte-kit.ts` (+5 -3) 📝 `packages/better-auth/src/oauth2/state.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/jwt/sign.ts` (+7 -4) 📝 `packages/better-auth/src/plugins/magic-link/index.ts` (+2 -2) 📝 `packages/better-auth/src/plugins/mcp/index.ts` (+7 -2) 📝 `packages/better-auth/src/plugins/oauth-proxy/index.ts` (+2 -2) 📝 `packages/better-auth/src/plugins/oidc-provider/index.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/passkey/index.ts` (+4 -4) 📝 `packages/better-auth/src/telemetry/index.ts` (+2 -3) 📝 `packages/better-auth/src/test-utils/index.ts` (+3 -1) 📝 `packages/better-auth/src/test-utils/test-instance.ts` (+3 -1) 📝 `packages/better-auth/src/types/options.ts` (+10 -3) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Added support for async and per-request baseURL resolution in Better Auth, allowing dynamic baseURL values using a function. - **New Features** - baseURL can now be a function that receives the request and context, and returns a string or Promise. - All internal usage and plugins updated to handle dynamic baseURL values. - New tests added for async baseURL scenarios. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:10:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5103
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?