github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3944] [MERGED] fix(telemetry): ensure telemetry consent notice displays correctly #5101

New Issue
Closed
opened 2026-03-13 12:10:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:10:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3944
Author: @frectonz
Created: 8/12/2025
Status: ✅ Merged
Merged: 8/12/2025
Merged by: @Bekacru

Base: canary ← Head: fix/telemetry-notice-fixes

📝 Commits (3)

  • f3c63bf fix(telemetry): ensure telemetry consent notice displays correctly
  • 05c6dfb chore: check for process
  • f1c09f9 chore: fix lint error

📊 Changes

1 file changed (+42 additions, -20 deletions)

View changed files

📝 packages/better-auth/src/telemetry/index.ts (+42 -20)

📄 Description

This PR fixes two bugs:

  • Telemetry debug mode was being enabled by default because getBooleanEnvVar has a true set as its default fallback, so this means telemetry debug was being enabled by default and telemetry notice was being disabled by default.
  • hasShownNoticeBefore was returning true if it failed to read the telemetry.json file, which means for the first install it will always return true, and the notice will never be printed.

Summary by cubic

Fixed telemetry consent notice so it displays correctly on first install and respects debug and disable settings.

  • Bug Fixes
  • Telemetry debug mode and notice are now disabled by default unless explicitly enabled.
  • Consent notice now shows on first install as intended.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3944 **Author:** [@frectonz](https://github.com/frectonz) **Created:** 8/12/2025 **Status:** ✅ Merged **Merged:** 8/12/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/telemetry-notice-fixes` --- ### 📝 Commits (3) - [`f3c63bf`](https://github.com/better-auth/better-auth/commit/f3c63bfa05cf0edf913bb5128654eb230ec70bbc) fix(telemetry): ensure telemetry consent notice displays correctly - [`05c6dfb`](https://github.com/better-auth/better-auth/commit/05c6dfb1504d6e295e078f9e0cdc01e40510f03f) chore: check for process - [`f1c09f9`](https://github.com/better-auth/better-auth/commit/f1c09f94ce15e8f0bd77110cd31c7beb40b72c06) chore: fix lint error ### 📊 Changes **1 file changed** (+42 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/telemetry/index.ts` (+42 -20) </details> ### 📄 Description This PR fixes two bugs: - Telemetry debug mode was being enabled by default because `getBooleanEnvVar` has a `true` set as its default fallback, so this means telemetry debug was being enabled by default and telemetry notice was being disabled by default. - `hasShownNoticeBefore` was returning true if it failed to read the `telemetry.json` file, which means for the first install it will always return true, and the notice will never be printed. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed telemetry consent notice so it displays correctly on first install and respects debug and disable settings. - **Bug Fixes** - Telemetry debug mode and notice are now disabled by default unless explicitly enabled. - Consent notice now shows on first install as intended. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:10:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?