github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3932] [MERGED] Add organization membership check before updating member role #5094

New Issue
Closed
opened 2026-03-13 12:10:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:10:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3932
Author: @max-om
Created: 8/11/2025
Status: ✅ Merged
Merged: 8/11/2025
Merged by: @Bekacru

Base: canary ← Head: crud-members-patch

📝 Commits (4)

  • 01e5f80 Add organization membership check before updating member role
  • 3efc67c Fix lint error
  • 60859a3 Merge branch 'canary' into crud-members-patch
  • 35b2334 add test

📊 Changes

2 files changed (+131 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/plugins/organization/routes/crud-members.test.ts (+121 -0)
📝 packages/better-auth/src/plugins/organization/routes/crud-members.ts (+10 -0)

📄 Description

closes #3933

Summary by cubic

Added a check to ensure a member belongs to the organization before allowing their role to be updated. This prevents unauthorized role changes for users outside the organization.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3932 **Author:** [@max-om](https://github.com/max-om) **Created:** 8/11/2025 **Status:** ✅ Merged **Merged:** 8/11/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `crud-members-patch` --- ### 📝 Commits (4) - [`01e5f80`](https://github.com/better-auth/better-auth/commit/01e5f8098f32331abf32a4a244f7c87d065c3a85) Add organization membership check before updating member role - [`3efc67c`](https://github.com/better-auth/better-auth/commit/3efc67cefbe0cb2cfe91784886c55196cca8da4a) Fix lint error - [`60859a3`](https://github.com/better-auth/better-auth/commit/60859a3dcba4b17bb2eb0384082c67cb79bcadb4) Merge branch 'canary' into crud-members-patch - [`35b2334`](https://github.com/better-auth/better-auth/commit/35b233481bc1f48d0c91657e29c8e180618c22bb) add test ### 📊 Changes **2 files changed** (+131 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/organization/routes/crud-members.test.ts` (+121 -0) 📝 `packages/better-auth/src/plugins/organization/routes/crud-members.ts` (+10 -0) </details> ### 📄 Description closes #3933 <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Added a check to ensure a member belongs to the organization before allowing their role to be updated. This prevents unauthorized role changes for users outside the organization. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:10:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5094
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?