github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3846] [MERGED] fix: client id is unused for TikTok social provider #5047

New Issue
Closed
opened 2026-03-13 12:09:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:09:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3846
Author: @himself65
Created: 8/7/2025
Status: ✅ Merged
Merged: 8/7/2025
Merged by: @Bekacru

Base: canary ← Head: himself65/2025/08/06/tiktoc

📝 Commits (2)

  • 7b3b055 fix: client id is unused for TikTok social provider
  • 6bcfbde fix: set header

📊 Changes

4 files changed (+24 additions, -11 deletions)

View changed files

📝 packages/better-auth/src/oauth2/refresh-access-token.ts (+9 -5)
📝 packages/better-auth/src/oauth2/types.ts (+5 -1)
📝 packages/better-auth/src/oauth2/validate-authorization-code.ts (+2 -2)
📝 packages/better-auth/src/social-providers/tiktok.ts (+8 -3)

📄 Description

Fixes: https://github.com/better-auth/better-auth/issues/3828

Summary by cubic

Removed the unused clientId field from the TikTok social provider to match TikTok's requirements and prevent configuration errors.

  • Bug Fixes
    • Updated TikTok provider options to exclude clientId.
    • Adjusted related OAuth2 functions to handle providers without clientId.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3846 **Author:** [@himself65](https://github.com/himself65) **Created:** 8/7/2025 **Status:** ✅ Merged **Merged:** 8/7/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `himself65/2025/08/06/tiktoc` --- ### 📝 Commits (2) - [`7b3b055`](https://github.com/better-auth/better-auth/commit/7b3b055f08d396df136944759d4b6fe9ebb3725e) fix: client id is unused for TikTok social provider - [`6bcfbde`](https://github.com/better-auth/better-auth/commit/6bcfbdeb75c96ed32790510da4d7792c730a793e) fix: set header ### 📊 Changes **4 files changed** (+24 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/oauth2/refresh-access-token.ts` (+9 -5) 📝 `packages/better-auth/src/oauth2/types.ts` (+5 -1) 📝 `packages/better-auth/src/oauth2/validate-authorization-code.ts` (+2 -2) 📝 `packages/better-auth/src/social-providers/tiktok.ts` (+8 -3) </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/issues/3828 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removed the unused clientId field from the TikTok social provider to match TikTok's requirements and prevent configuration errors. - **Bug Fixes** - Updated TikTok provider options to exclude clientId. - Adjusted related OAuth2 functions to handle providers without clientId. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:09:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#5047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?