github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-13 08:22:29 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3778] [CLOSED] fix(adapter): kysely adapter renamed fields #4999

New Issue
Closed
opened 2026-03-13 12:06:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:06:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3778
Author: @Kinfe123
Created: 8/4/2025
Status: ❌ Closed

Base: canary ← Head: fix/kysely-adapter-renamed-fields

📝 Commits (10+)

📊 Changes

14 files changed (+126 additions, -7 deletions)

View changed files

📝 packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.mysql.test.ts (+5 -0)
📝 packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.test.ts (+5 -0)
📝 packages/better-auth/src/adapters/drizzle-adapter/test/schema.mysql.ts (+2 -1)
📝 packages/better-auth/src/adapters/drizzle-adapter/test/schema.ts (+2 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts (+14 -2)
📝 packages/better-auth/src/adapters/kysely-adapter/test/normal/adapter.kysely.test.ts (+5 -0)
📝 packages/better-auth/src/adapters/kysely-adapter/test/number-id/adapter.kysely.number-id.test.ts (+5 -0)
📝 packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts (+9 -2)
📝 packages/better-auth/src/adapters/prisma-adapter/test/normal-tests/adapter.prisma.test.ts (+5 -0)
📝 packages/better-auth/src/adapters/prisma-adapter/test/normal-tests/schema.prisma (+9 -0)
📝 packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/adapter.prisma.number-id.test.ts (+5 -0)
📝 packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/schema.prisma (+9 -0)
📝 packages/better-auth/src/adapters/test.ts (+49 -0)
📝 packages/better-auth/src/db/get-migration.ts (+2 -1)

📄 Description

The fix addresses the issue where the Kysely adapter couldn't find field definitions for renamed fields, preventing proper data transformation like date and other and causing database binding errors as attached below
Screenshot 2025-08-04 at 2 10 28 PM
. The solution addresses create-adapter's getDefaultFieldName function to properly handle renamed fields.

Summary by cubic

Fixed an issue where the Kysely adapter could not handle renamed fields, which caused data transformation errors and database binding failures.

  • Bug Fixes
    • Updated field lookup logic to support renamed fields in the schema.
    • Added tests to cover renamed verification fields.

closes #3683

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3778 **Author:** [@Kinfe123](https://github.com/Kinfe123) **Created:** 8/4/2025 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/kysely-adapter-renamed-fields` --- ### 📝 Commits (10+) - [`02b99fb`](https://github.com/better-auth/better-auth/commit/02b99fb92d7e8e116cf22c344e0ec4e604c44a5c) fix: handle renamed fields in kysely adapter transformValueToDB function - [`3f0f1c9`](https://github.com/better-auth/better-auth/commit/3f0f1c9e49c3e76c90a8243f1949712839c11768) lint - [`4b7f97d`](https://github.com/better-auth/better-auth/commit/4b7f97d9e502c7308c7d6dc45932aaca42a0d272) changesets - [`035371e`](https://github.com/better-auth/better-auth/commit/035371ed5397bd3dc439c7df81b1d2a624ea54a6) test - [`59579b1`](https://github.com/better-auth/better-auth/commit/59579b10c6e7991b65ad19fa969809c1a48b9d44) update - [`6c3ae80`](https://github.com/better-auth/better-auth/commit/6c3ae808da8ac72dd35d257a3e1bcb10ebd4fb48) test - [`e2ee046`](https://github.com/better-auth/better-auth/commit/e2ee0468ff11d9a3e0a7282ff42bb0c33254474b) update - [`8049768`](https://github.com/better-auth/better-auth/commit/8049768214fdf36e72bef472b236222a2a399ced) test - [`5ff435a`](https://github.com/better-auth/better-auth/commit/5ff435a2df0a52df6ecbb51d6b1b6788a175bbbd) chore: remove changeset - [`c586e3c`](https://github.com/better-auth/better-auth/commit/c586e3c6e8823bb4a399bc1d3fb01ee4f4bc83a3) update ### 📊 Changes **14 files changed** (+126 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.mysql.test.ts` (+5 -0) 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.test.ts` (+5 -0) 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/schema.mysql.ts` (+2 -1) 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/schema.ts` (+2 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts` (+14 -2) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/normal/adapter.kysely.test.ts` (+5 -0) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/number-id/adapter.kysely.number-id.test.ts` (+5 -0) 📝 `packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts` (+9 -2) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/normal-tests/adapter.prisma.test.ts` (+5 -0) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/normal-tests/schema.prisma` (+9 -0) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/adapter.prisma.number-id.test.ts` (+5 -0) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/number-id-tests/schema.prisma` (+9 -0) 📝 `packages/better-auth/src/adapters/test.ts` (+49 -0) 📝 `packages/better-auth/src/db/get-migration.ts` (+2 -1) </details> ### 📄 Description The fix addresses the issue where the Kysely adapter couldn't find field definitions for renamed fields, preventing proper data transformation like date and other and causing database binding errors as attached below <img width="673" height="145" alt="Screenshot 2025-08-04 at 2 10 28 PM" src="https://github.com/user-attachments/assets/b29c2062-b045-4dab-a2b1-a89e9ae06a5e" /> . The solution addresses create-adapter's getDefaultFieldName function to properly handle renamed fields. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed an issue where the Kysely adapter could not handle renamed fields, which caused data transformation errors and database binding failures. - **Bug Fixes** - Updated field lookup logic to support renamed fields in the schema. - Added tests to cover renamed verification fields. closes #3683 <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:06:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4999
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?