github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3691] [MERGED] Chore: remove unnecessary console log #4956

New Issue
Closed
opened 2026-03-13 12:05:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:05:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3691
Author: @RobiMez
Created: 7/29/2025
Status: ✅ Merged
Merged: 7/29/2025
Merged by: @Bekacru

Base: main ← Head: main

📝 Commits (3)

  • adf3e3a chore: cleanup log
  • 83f8ae3 Merge branch 'better-auth:main' into main
  • 455cec3 chore: add changeset

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

➕ .changeset/tasty-teachers-compete.md (+5 -0)
📝 packages/better-auth/src/api/rate-limiter/index.ts (+0 -1)

📄 Description

from this discord thread https://discord.com/channels/1288403910284935179/1399024049690116116

there is a console.warn("No IP address found for rate limiting"); on the rate limit plugin that logs when the ip to rate limit is not found that may occur often. since it isnt that important for using the library , this reduces the noise.

image

Summary by cubic

Removed a console warning in the rate limiter that logged when no IP address was found, reducing unnecessary log noise.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3691 **Author:** [@RobiMez](https://github.com/RobiMez) **Created:** 7/29/2025 **Status:** ✅ Merged **Merged:** 7/29/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`adf3e3a`](https://github.com/better-auth/better-auth/commit/adf3e3ac7e419761a43a61b47019ce471d8f60e5) chore: cleanup log - [`83f8ae3`](https://github.com/better-auth/better-auth/commit/83f8ae326244d7e9fd0af7ef34e0843fe144c216) Merge branch 'better-auth:main' into main - [`455cec3`](https://github.com/better-auth/better-auth/commit/455cec323108bb78a5263720ea5d9d7bf07b00a9) chore: add changeset ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/tasty-teachers-compete.md` (+5 -0) 📝 `packages/better-auth/src/api/rate-limiter/index.ts` (+0 -1) </details> ### 📄 Description from this discord thread https://discord.com/channels/1288403910284935179/1399024049690116116 there is a console.warn("No IP address found for rate limiting"); on the rate limit plugin that logs when the ip to rate limit is not found that may occur often. since it isnt that important for using the library , this reduces the noise. <img width="972" height="719" alt="image" src="https://github.com/user-attachments/assets/716c0b23-50b3-4e6b-9208-a22ced89a1d9" /> <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removed a console warning in the rate limiter that logged when no IP address was found, reducing unnecessary log noise. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:05:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4956
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?