github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-07-24 08:58:45 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3610] [CLOSED] fix(admin-plugin) list user endpoint incorrect return type #4912

New Issue
Closed
opened 2026-03-13 12:04:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:04:00 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3610
Author: @shahriar-shojib
Created: 7/25/2025
Status: ❌ Closed

Base: main ← Head: fix/list-user-response-type

📝 Commits (1)

  • 42f8376 fix(admin-plugin) list user endpoint incorrect return type

📊 Changes

1 file changed (+7 additions, -7 deletions)

View changed files

📝 packages/better-auth/src/plugins/admin/admin.ts (+7 -7)

📄 Description

Previously, the return type of auth.admin.listUsers was awkward, which required casting types forcefully

{
    users: UserWithRole[];
    total: number;
    limit: number | undefined;
    offset: number | undefined;
} | {
    users: never[];
    total: number;
}

Now it's

{
    users: UserWithRole[];
    total: number;
}

Summary by cubic

Fixed the return type of the admin list users endpoint to always return a consistent object shape with a typed users array and total count. This removes the need for type casting when handling empty user lists.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3610 **Author:** [@shahriar-shojib](https://github.com/shahriar-shojib) **Created:** 7/25/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/list-user-response-type` --- ### 📝 Commits (1) - [`42f8376`](https://github.com/better-auth/better-auth/commit/42f8376dc6a0769e154c0d9bcf2cdb8f6fe23c37) fix(admin-plugin) list user endpoint incorrect return type ### 📊 Changes **1 file changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/admin/admin.ts` (+7 -7) </details> ### 📄 Description Previously, the return type of `auth.admin.listUsers` was awkward, which required casting types forcefully ```ts { users: UserWithRole[]; total: number; limit: number | undefined; offset: number | undefined; } | { users: never[]; total: number; } ``` Now it's ```ts { users: UserWithRole[]; total: number; } ``` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed the return type of the admin list users endpoint to always return a consistent object shape with a typed users array and total count. This removes the need for type casting when handling empty user lists. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:04:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4912