github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3565] [CLOSED] fix: preserve undefined tokens when encrypting #4885

New Issue
Closed
opened 2026-03-13 12:03:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 12:03:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3565
Author: @tinkerer-shubh
Created: 7/23/2025
Status: ❌ Closed

Base: main ← Head: fix-3559-setTokenUtil

📝 Commits (1)

  • a9c720e fix: preserve undefined tokens when encrypting

📊 Changes

4 files changed (+10 additions, -5 deletions)

View changed files

📝 packages/better-auth/src/api/routes/callback.ts (+1 -1)
📝 packages/better-auth/src/oauth2/link-account.ts (+1 -1)
📝 packages/better-auth/src/oauth2/utils.ts (+7 -2)
📝 packages/better-auth/src/plugins/generic-oauth/index.ts (+1 -1)

📄 Description

possibly closes https://github.com/better-auth/better-auth/issues/3559

Summary by cubic

Fixed token handling to preserve undefined values during encryption, preventing accidental overwrites of missing tokens.

  • Bug Fixes
    • Updated token filtering to distinguish between null and undefined values.
    • Ensured setTokenUtil returns undefined tokens as-is.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3565 **Author:** [@tinkerer-shubh](https://github.com/tinkerer-shubh) **Created:** 7/23/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-3559-setTokenUtil` --- ### 📝 Commits (1) - [`a9c720e`](https://github.com/better-auth/better-auth/commit/a9c720e13c883783997eec589dc59a33c664450c) fix: preserve undefined tokens when encrypting ### 📊 Changes **4 files changed** (+10 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/callback.ts` (+1 -1) 📝 `packages/better-auth/src/oauth2/link-account.ts` (+1 -1) 📝 `packages/better-auth/src/oauth2/utils.ts` (+7 -2) 📝 `packages/better-auth/src/plugins/generic-oauth/index.ts` (+1 -1) </details> ### 📄 Description possibly closes https://github.com/better-auth/better-auth/issues/3559 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed token handling to preserve undefined values during encryption, preventing accidental overwrites of missing tokens. - **Bug Fixes** - Updated token filtering to distinguish between null and undefined values. - Ensured setTokenUtil returns undefined tokens as-is. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 12:03:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4885
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?