github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3284] [MERGED] fix: import setCookie from tanstack start core package #4735

New Issue
Closed
opened 2026-03-13 11:58:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:58:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3284
Author: @asterikx
Created: 7/7/2025
Status: ✅ Merged
Merged: 7/7/2025
Merged by: @Bekacru

Base: main ← Head: fix/tanstack-start-cookies

📝 Commits (1)

  • 5c5ef02 fix: import setCookie from tanstack start core package

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 packages/better-auth/src/integrations/react-start.ts (+1 -3)

📄 Description

This PR enables to use the Tanstack Start integration with both the React and the Solid flavor of Tanstack Start.

Previously, the setCookie method was imported from @tanstack/react-start which is typically not installed in projects using the Solid flavor.
By importing setCookie from the core package @tanstack/start-server-core, this integration works regardless of whether @tanstack/react-start or @tanstack/solid-start is used.
The framework-specific packages re-export thesetCookie method from the core package (here) without modification.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3284 **Author:** [@asterikx](https://github.com/asterikx) **Created:** 7/7/2025 **Status:** ✅ Merged **Merged:** 7/7/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/tanstack-start-cookies` --- ### 📝 Commits (1) - [`5c5ef02`](https://github.com/better-auth/better-auth/commit/5c5ef025f5fc29207b3a7252f8ab135b0ead073f) fix: import setCookie from tanstack start core package ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/integrations/react-start.ts` (+1 -3) </details> ### 📄 Description This PR enables to use the Tanstack Start integration with both the React and the Solid flavor of Tanstack Start. Previously, the `setCookie` method was imported from `@tanstack/react-start` which is typically not installed in projects using the Solid flavor. By importing `setCookie` from the core package `@tanstack/start-server-core`, this integration works regardless of whether `@tanstack/react-start` or `@tanstack/solid-start` is used. The framework-specific packages re-export the`setCookie` method from the core package ([here](https://github.com/TanStack/router/blob/b01a349583d92c9a8e21024bc9dcceb71ab08244/packages/react-start-server/src/index.tsx#L4)) without modification. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:58:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4735
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?