github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3271] [MERGED] fix(admin): throw an error if user id in /remove-user is invalid #4729

New Issue
Closed
opened 2026-03-13 11:57:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:57:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3271
Author: @ping-maxwell
Created: 7/5/2025
Status: ✅ Merged
Merged: 7/6/2025
Merged by: @Bekacru

Base: main ← Head: fix/admin/remove-user-throw-on-invalid-id

📝 Commits (2)

  • 493e83b fix(admin): Should throw an error if the user id in /remove-user is invalid
  • 72d3444 chore: lint

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/plugins/admin/admin.ts (+10 -0)

📄 Description

Right now if the user id is faked it still returns success: true. This shouldn't be the case, we should return an error if the user id is invalid.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3271 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 7/5/2025 **Status:** ✅ Merged **Merged:** 7/6/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/admin/remove-user-throw-on-invalid-id` --- ### 📝 Commits (2) - [`493e83b`](https://github.com/better-auth/better-auth/commit/493e83beda27e5c1216ba10701b6cd9698e2e3ec) fix(admin): Should throw an error if the user id in `/remove-user` is invalid - [`72d3444`](https://github.com/better-auth/better-auth/commit/72d3444b690b929a5f195d861a3a398b6d2f23bf) chore: lint ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/admin/admin.ts` (+10 -0) </details> ### 📄 Description Right now if the user id is faked it still returns `success: true`. This shouldn't be the case, we should return an error if the user id is invalid. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:57:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4729
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?