github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-09-01 02:55:08 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2983] [CLOSED] fix(auth): improve URL validation #4583

New Issue
Closed
opened 2026-03-13 11:51:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:51:46 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2983
Author: @aynaash
Created: 6/11/2025
Status: ❌ Closed

Base: main ← Head: fix/url-validation

📝 Commits (2)

  • 40124c1 fix(auth): improve URL validation
  • 0894bd5 fix(auth): ensure URL sanitization in withPath()

📊 Changes

1 file changed (+72 additions, -63 deletions)

View changed files

📝 packages/better-auth/src/utils/url.ts (+72 -63)

📄 Description

This PR fixes URL handling issues where:

Quoted URLs ("https://example.com") caused validation failures

Fixes:

Added URL sanitization to remove quotes/slashes
Added protocol validation (requires http:// or https://)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2983 **Author:** [@aynaash](https://github.com/aynaash) **Created:** 6/11/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/url-validation` --- ### 📝 Commits (2) - [`40124c1`](https://github.com/better-auth/better-auth/commit/40124c1864653b6a43a8461aba1c28b957ade907) fix(auth): improve URL validation - [`0894bd5`](https://github.com/better-auth/better-auth/commit/0894bd5e1c2918d4c5c6afbb0047fdd323c1e1cd) fix(auth): ensure URL sanitization in withPath() ### 📊 Changes **1 file changed** (+72 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/utils/url.ts` (+72 -63) </details> ### 📄 Description This PR fixes URL handling issues where: Quoted URLs ("https://example.com") caused validation failures Fixes: Added URL sanitization to remove quotes/slashes Added protocol validation (requires http:// or https://) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:51:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4583