github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2864] [MERGED] fix(stripe): inconsistency preventing subscription upgrades #4531

New Issue
Closed
opened 2026-03-13 11:50:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:50:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2864
Author: @rgodha24
Created: 6/1/2025
Status: ✅ Merged
Merged: 6/1/2025
Merged by: @Bekacru

Base: main ← Head: stripe-upgrading-bug

📝 Commits (1)

  • b76c4d7 fix(stripe): inconsistency preventing subscription upgrades

📊 Changes

1 file changed (+12 additions, -1 deletions)

View changed files

📝 packages/stripe/src/index.ts (+12 -1)

📄 Description

fixes #2860.

an alternative way of doing this that doesnt depend on the connector: "OR" pattern that I haven't seen anywhere else in the repo would be updating this line
96634ceefd/packages/stripe/src/index.ts (L260)
to this: (subscription) => subscription.id === subscriptionToUpdate?.stripeSubscriptionId,

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2864 **Author:** [@rgodha24](https://github.com/rgodha24) **Created:** 6/1/2025 **Status:** ✅ Merged **Merged:** 6/1/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `stripe-upgrading-bug` --- ### 📝 Commits (1) - [`b76c4d7`](https://github.com/better-auth/better-auth/commit/b76c4d7737de8b2589cea75b74aaa92341114f1f) fix(stripe): inconsistency preventing subscription upgrades ### 📊 Changes **1 file changed** (+12 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/stripe/src/index.ts` (+12 -1) </details> ### 📄 Description fixes #2860. an alternative way of doing this that doesnt depend on the `connector: "OR"` pattern that I haven't seen anywhere else in the repo would be updating this line https://github.com/better-auth/better-auth/blob/96634ceefd4605761eb183ae8ed3529b9eb1db3e/packages/stripe/src/index.ts#L260 to this: `(subscription) => subscription.id === subscriptionToUpdate?.stripeSubscriptionId,` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:50:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4531
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?