github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2621] [CLOSED] fix: uri-encode callbackURL for magic link to allow for query params #4405

New Issue
Closed
opened 2026-03-13 11:44:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 11:44:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2621
Author: @philipp-lampert
Created: 5/11/2025
Status: ❌ Closed

Base: main ← Head: fix/magic-link-callback-url

📝 Commits (1)

  • 6045b6f fix: uri-encode callbackURL for magic link to allow for query params

📊 Changes

1 file changed (+7 additions, -4 deletions)

View changed files

📝 packages/better-auth/src/plugins/magic-link/index.ts (+7 -4)

📄 Description

Fixes an issue preventing magic link authentication from correctly redirecting to callbackURLs with query parameters (e.g., /dashboard?view=reports&filter=last_month).

The fix involves:

  1. Properly URI-encoding the callbackURL when the magic link is generated.
  2. Correctly URI-decoding this callbackURL during the verification step before the redirect and for originCheck validation.

This is crucial for restoring post-login redirection to specific states.

Closes #2592

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2621 **Author:** [@philipp-lampert](https://github.com/philipp-lampert) **Created:** 5/11/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/magic-link-callback-url` --- ### 📝 Commits (1) - [`6045b6f`](https://github.com/better-auth/better-auth/commit/6045b6ff908b141d79d22d558e7a70cf95eb1f80) fix: uri-encode callbackURL for magic link to allow for query params ### 📊 Changes **1 file changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/magic-link/index.ts` (+7 -4) </details> ### 📄 Description Fixes an issue preventing magic link authentication from correctly redirecting to `callbackURL`s with query parameters (e.g., `/dashboard?view=reports&filter=last_month`). The fix involves: 1. Properly URI-encoding the `callbackURL` when the magic link is generated. 2. Correctly URI-decoding this `callbackURL` during the verification step before the redirect and for `originCheck` validation. This is crucial for restoring post-login redirection to specific states. Closes #2592 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 11:44:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#4405
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?